Upgrade Ray to 2.9.0. #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsowell
commented
Jan 8, 2024
sycamore/writers/file_writer.py
Outdated
|
|
||
| return "ok" | ||
| # Some of this code is taken from Ray's FileBasedDatasource. We should switch to using that |
There was a problem hiding this comment.
Ah sorry. Will delete this.
alexaryn
approved these changes
Jan 8, 2024
This consists two main changes: - The file_writer implementation has changed from using some internal Ray APIs to the new Datasink API. - Modified the predicate in the Sketcher implementation to use a CallableClass. Not quite sure how this was working before, but Ray now enforces that CalableClasses are used with the ActorPoolStrategy.
bohou-aryn
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consists two main changes:
The file_writer implementation has changed from using some internal Ray APIs to the new Datasink API.
Modified the predicate in the Sketcher implementation to use a CallableClass. Not quite sure how this was working before, but Ray now enforces that CalableClasses are used with the ActorPoolStrategy.