Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bank code review #1

Open
wants to merge 12 commits into
base: review
Choose a base branch
from
Open

Bank code review #1

wants to merge 12 commits into from

Conversation

asaid997
Copy link
Owner

No description provided.

Copy link

@ameliawalcek ameliawalcek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great job.

@@ -0,0 +1,41 @@
import Transactions from "./transactions";
import M from 'materialize-css'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should be using bootstrap or material UI for react applications


const categories = {}

transactions.forEach(t => categories[t.category] ? categories[t.category].push(t) : categories[t.category] = [t])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use .map() it creates an array

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants