Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLD for physical devices does not pick up spares due to regex #11

Closed
rozniak opened this issue Jun 11, 2019 · 1 comment
Closed

LLD for physical devices does not pick up spares due to regex #11

rozniak opened this issue Jun 11, 2019 · 1 comment

Comments

@rozniak
Copy link

rozniak commented Jun 11, 2019

Hey,

I found a problem with the LLD portion of the script that detects physical drives - I noticed that one of the disks in an array I'm monitoring doesn't show up in Zabbix.

I found the problem lies in the regex for pulling the drive info out of the CLI tool, particularly here is the output of the CLI on my affected system:

C:\Program Files\hp\hpssacli\bin>hpssacli.exe ctrl slot=0 pd all show status

physicaldrive 1I:2:1 (port 1I:box 2:bay 1, 1 TB): OK
physicaldrive 1I:2:2 (port 1I:box 2:bay 2, 1 TB): OK
physicaldrive 1I:2:3 (port 1I:box 2:bay 3, 1 TB): OK
physicaldrive 1I:2:4 (port 1I:box 2:bay 4, 1 TB): OK
physicaldrive 2I:2:5 (port 2I:box 2:bay 5, 1 TB, spare): OK

That last drive isn't detected because of the ", spare" bit, I have been able to solve the regex issue in my fork - the commit is here: rozniak@604b106

I hope this helps! 👍

@asand3r
Copy link
Owner

asand3r commented Jun 11, 2019

Hi, @rozniak
Thank you for report. Yeap, I've got it and will correct regular expression to support spare drives as soon as posible. =)

asand3r added a commit that referenced this issue Jun 11, 2019
2. Renamed main PS script to lowercase to follow consistency with my other scripts.
@asand3r asand3r closed this as completed Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants