Skip to content

Commit

Permalink
Rename ActiveRecord::Base.each to ActiveRecord::Base.find_each
Browse files Browse the repository at this point in the history
  • Loading branch information
lifo committed Mar 11, 2009
1 parent 19ad375 commit 0433348
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 7 deletions.
3 changes: 1 addition & 2 deletions activerecord/CHANGELOG
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
*2.3.1 [RC2] (March 5, 2009)*

* Added ActiveRecord::Base.each and ActiveRecord::Base.find_in_batches for batch processing [DHH/Jamis Buck]
* Added ActiveRecord::Base.find_each and ActiveRecord::Base.find_in_batches for batch processing [DHH/Jamis Buck]

* Added that ActiveRecord::Base.exists? can be called with no arguments #1817 [Scott Taylor]


*2.3.0 [RC1] (February 1st, 2009)*

* Add Support for updating deeply nested models from a single form. #1202 [Eloy Duran]
Expand Down
4 changes: 2 additions & 2 deletions activerecord/lib/active_record/batches.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@ module ClassMethods
#
# Example:
#
# Person.each(:conditions => "age > 21") do |person|
# Person.find_each(:conditions => "age > 21") do |person|
# person.party_all_night!
# end
#
# Note: This method is only intended to use for batch processing of large amounts of records that wouldn't fit in
# memory all at once. If you just need to loop over less than 1000 records, it's probably better just to use the
# regular find methods.
def each(options = {})
def find_each(options = {})
find_in_batches(options) do |records|
records.each { |record| yield record }
end
Expand Down
6 changes: 3 additions & 3 deletions activerecord/test/cases/batches_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,21 +11,21 @@ def setup

def test_each_should_excecute_one_query_per_batch
assert_queries(Post.count + 1) do
Post.each(:batch_size => 1) do |post|
Post.find_each(:batch_size => 1) do |post|
assert_kind_of Post, post
end
end
end

def test_each_should_raise_if_the_order_is_set
assert_raise(RuntimeError) do
Post.each(:order => "title") { |post| post }
Post.find_each(:order => "title") { |post| post }
end
end

def test_each_should_raise_if_the_limit_is_set
assert_raise(RuntimeError) do
Post.each(:limit => 1) { |post| post }
Post.find_each(:limit => 1) { |post| post }
end
end

Expand Down

0 comments on commit 0433348

Please sign in to comment.