Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loki branch - Auto saving feature #437

Closed
popxunga opened this issue Mar 3, 2020 · 11 comments · Fixed by #438
Closed

Loki branch - Auto saving feature #437

popxunga opened this issue Mar 3, 2020 · 11 comments · Fixed by #438

Comments

@popxunga
Copy link

popxunga commented Mar 3, 2020

Hi Team ...

I do have the "Auto save config changes" unchecked in the Main Preferences.
image

Upon Asbru startup, the push button next to the Preferences button, has a grayed out "Save" legend:
image

Whenever I modify and save something in the Main Preferences dialog or in some Node configuration, the button gets updated with a grayed out "Auto saving ACTIVE" legend:
image

Why is the Auto Saving (apparently!) being turned on when I've it off in the Main Preferences ?
May you please explain how this feature is supposed to work ?

Thanks.

@hanspr
Copy link
Contributor

hanspr commented Mar 3, 2020

Please send an exported configuration to be able to check

Preferencies > Export > DEBUG data

@popxunga
Copy link
Author

popxunga commented Mar 3, 2020

Hi @hanspr

Just tested it and it happens with a vanilla configuration.
So no need to send the configuration export I guess.

BTW the anonymized export configuration needs improvement (more configuration fields needs to be anonymized).

Thanks.

@gfrenoy
Copy link
Contributor

gfrenoy commented Mar 3, 2020

First, the theory: "Auto save config changes" inside the "At exit" section means that any change will be automatically saved when you exit the software.

Now, in practice, when you have "Automatically save every configuration change" checked, it does not really make sense to have this other option since all changes are immediately saved so, for sure, when exiting, whatever you chose, there's nothing more to save.

When you see "Auto saving ACTIVE", it's actually related to the other parameter on the same panel ("Automatically save every configuration change").

From here, I have some more questions to brainstorm this further:

  • Should we hide "At exit" > "Auto save config changes" when "Automatically save every configuration change" is checked ?
  • Should we change the text / tool tip to make it clearer ?
  • Any other thought ?

@gfrenoy gfrenoy added the question Question about how to use Ásbrú or how to work with some specific connection type. label Mar 3, 2020
@hanspr hanspr mentioned this issue Mar 3, 2020
@hanspr
Copy link
Contributor

hanspr commented Mar 3, 2020

@popxunga

BTW the anonymized export configuration needs improvement (more configuration fields needs to be anonymized).

Could you open a new issue pointing the fields that you have detected that need to be anonymized?

@popxunga
Copy link
Author

popxunga commented Mar 3, 2020

Hi @gfrenoy
I didn't notice the other option "Automatically save every configuration change".
My suggestion is automatically uncheck and gray out the "Auto save config changes" option whenever the "Automatically save every configuration change" option is checked.
Thanks.

@popxunga
Copy link
Author

popxunga commented Mar 3, 2020

@popxunga

BTW the anonymized export configuration needs improvement (more configuration fields needs to be anonymized).

Could you open a new issue pointing the fields that you have detected that need to be anonymized?

Here
Thanks !

@gfrenoy gfrenoy added enhancement and removed question Question about how to use Ásbrú or how to work with some specific connection type. labels Mar 4, 2020
gfrenoy added a commit that referenced this issue Mar 4, 2020
@gfrenoy
Copy link
Contributor

gfrenoy commented Mar 4, 2020

We made some changes to the preferences panel ; let us know if this makes things clearer.

@popxunga
Copy link
Author

popxunga commented Mar 5, 2020

We made some changes to the preferences panel ; let us know if this makes things clearer.

Hi @gfrenoy
I think its better now.
Thanks !

@gfrenoy
Copy link
Contributor

gfrenoy commented Mar 5, 2020

Cool ! Should we consider this closed ?

@popxunga
Copy link
Author

popxunga commented Mar 5, 2020

Hi @gfrenoy ...
Yes.. I guess we can ;-)
Maybe in the future we should consider grouping the Preferences settings in some tabs within some rectangles... sometimes the disposition looks a bit fuzzy which makes reading a bit difficult.
Thanks.

@gfrenoy
Copy link
Contributor

gfrenoy commented Mar 6, 2020

Yes, a lot of work on UI/UX ; that goes far beyond the current issue. Let's close this for now. Thanks for the valuable feedback !

@gfrenoy gfrenoy closed this as completed Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants