Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] - User variables doesn't work #29

Merged
merged 1 commit into from Nov 29, 2017
Merged

Conversation

merikz
Copy link
Contributor

@merikz merikz commented Nov 29, 2017

This fixes Issue #28.
Technically the problem was that:

  • The {txt} hash key was not referenced when replacing user variables

As the User Variables have been broken in PAC since forever it seems, I guess people do not use it.
Here's how I use it:
Create a template connection, with values as <V:0>, <V:1> wherever unique values are needed, such as ip-address, jump hosts, proxies and user name. Then just copy the connection and change all the connection unique values on the User Variables tab, instead of hunting down the different places that needs to be changed.

https://sourceforge.net/p/pacmanager/bugs/249/
Issue #28

  - The {txt} hash key not referenced when replacing user variables
  - Context menu showed HASH(0xABACAB) as value.
  https://sourceforge.net/p/pacmanager/bugs/249/
  asbru-cm#28
@gfrenoy gfrenoy merged commit 80c301d into asbru-cm:master Nov 29, 2017
@gfrenoy
Copy link
Contributor

gfrenoy commented Nov 29, 2017

Thanks a lot Magnus. Maybe we should have a PACUtils function for the transformation ? Anyway, it should work.

And indeed, must not be much used. I remember I tried a couple of weeks ago but could not make it working so I gave up :-/ Probably a page in the wiki explaining the purpose and giving an example would help...

@merikz
Copy link
Contributor Author

merikz commented Nov 29, 2017

There are a lot of features hidden in Asbru, that you only find after much exploration. An introduction for newcomers on the wiki might be a good thing? Problem is that I'm not a newcomer anymore, so I don't remember the difficulties. Maybe add a "help wanted" on the issue list?
IMHO tool-tips could be used to help users get going, if done right.

Anyway, I have an extension of the User Variables coming up, merging User Variables and Global Variables so User Variables also gets names instead of numbers. I made it 3 years ago, but this was a bit more work to port to asbru. PR in the works.

@merikz merikz deleted the uservars branch January 19, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants