Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boxes.el history list nil #17

Closed
carnil opened this issue Dec 6, 2015 · 3 comments
Closed

boxes.el history list nil #17

carnil opened this issue Dec 6, 2015 · 3 comments
Labels
bug The boxes tool behaves incorrectly

Comments

@carnil
Copy link
Contributor

carnil commented Dec 6, 2015

Hi

In Debian I got a report about the boxes.el (I'm not an emacs user myself), so I'm just forwarding it

From: Kevin Ryde <user42_kevin@yahoo.com.au>
To: Debian Bug Tracking System <maintonly@bugs.debian.org>
Subject: boxes: boxes.el history list nil
Date: Sun, 06 Dec 2015 16:33:09 +1100

Package: boxes
Version: 1.1.2-3
Severity: minor
Tags: patch
File: /usr/share/emacs/site-lisp/boxes.el

In boxes.el the boxes-history variable is set to (list nil) but nil is
not a string.  You can see the effect by trying to step back to it,

    M-x boxes-command-on-region
    M-p
    =>
    previous-history-element: Wrong type argument: char-or-string-p, nil

Usually an empty history variable is made just by

    (defvar boxes-history nil)

Original report is at: https://bugs.debian.org/807153

Regards,
Salvatore

@tsjensen
Copy link
Member

tsjensen commented Dec 6, 2015

Thank you Salvatore. @zerotao, I know it's many years old, but can you have a look at this?

@zerotao
Copy link
Contributor

zerotao commented Dec 6, 2015

Sure, I'll take a look and fix it.

tsjensen added a commit that referenced this issue Dec 10, 2015
fix issue #17 boxes.el history list nil
@tsjensen
Copy link
Member

Fixed in #18 by @zerotao - Thanks!!

@tsjensen tsjensen added the bug The boxes tool behaves incorrectly label Dec 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The boxes tool behaves incorrectly
Projects
None yet
Development

No branches or pull requests

3 participants