Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.14.0 #519

Open
wants to merge 113 commits into
base: master
Choose a base branch
from
Open

Release 0.14.0 #519

wants to merge 113 commits into from

Conversation

caphm
Copy link
Collaborator

@caphm caphm commented Nov 4, 2018

Please help test this before it gets merged!

For testing purposes, you can install via zip file (download Code of last commit) or directly from my repo: https://github.com/caphm/kodi-repo/raw/master/repository.kodi-repo-caphm/repository.kodi-repo-caphm-1.0.0.zip
(new commits to this PR will be pushed to this repo as new beta versions)

This is a big one: While running down the list of bugs to fix, I have heavily refactored the entire addon (and essentially rewritten most of the code).

The major changes are:

  • Replace Netflix HTTP Service with AddonSignals: This has lead to major performance improvements, because we're losing the HTTP overhead. The architecture is still split into a backend which manages a persistent Netflix session and a frontend, which queries the API via IPC calls using AddonSignals. Due to this split, there can still occurr timeouts, when an operation is taking too long in the backend. I have not encountered this in my tests though.
  • Improved maintainability: Everything was written with maintainability in mind. Large files were broken up into parts and everything is much more modularized. On Codeclimate, the entire codebase currently scores an A in maintainability.
  • Improved caching: Almost all parts in the frontend make use of extensive caching. The cached items have a TTL depending on their content type (metadata lives longer, as it rarely changes), thus you will no longer see the same video lists when running Kodi for a long time without restarts. The cache is also properly invalidated on profile switches (which works better now as well, more later). Some items (infolabels and artwork info) are cached to disk, so they persist between Kodi restarts. You can configure the TTL for different content types in the settings, to suit your needs. Relevant items in the cache are also invalidated on certain API operations, so you'll instantly see that new show you added to my list actually show up when browsing my list.
  • Fully unicode compatible: Everything was written with full unicode compatibility in mind. I have tested with exotic unicode characters in profile names, website language, etc. Because Kodi still intransparently mangles some strings into non-unicode, there still might some bugs I didn't find during testing.
  • Discover more content: From the main menu, you're now able to browse video lists for all shows and all movies. This does not yet list them from A-Z but rather displays the videolists that are also displayed on the Netflix website, but this is on my todo list. When browsing a video list with a genre context, you can also browse more related content (more video lists). Essentially, you can recursively browse vast parts of the netflix catalogue.
  • Improved library integration: In the settings you can enable to keep My List and the Kodi library in sync: Everthing you add to My List from within the addon, will also be exported to the library. Everything you remove from My List, will be removed from the library. There is an option to do a full sync, which resets your exported items and exports everything from My List. Be careful when using this!
  • Display everything: There is no longer an upper limit for the number of items to be displayed in a single listing. Seasons with more than 40 episodes will display all of them at once. If you have more than 40 items in My List, they will all be displayed.
  • Improved error handling: There should be no more cryptic error messages (or at least very few of them). Errors returned by Netflix are displayed as they are on the Website (e.g. when you're using a proxy). Every error is logged in detail and instruction son how to report new errors are provided.

In my experience this is all around faster, better, stronger ;)
Before this is released though, I'd like to have some feedback and ideally a couple of beta testers who really try to break it.

I will add some more changes to this in the future (Up Next integration, more features), but I believe this is ready for prime time.

Finally, here comes the list of bugfixes:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully ran tests with your changes locally?

@asciidisco
Copy link
Owner

This is the thing I always wanted & never got the time to actually do. Wow.
Thanks so much for taking over, I´ll review the PR within the next few days.

@joaosagrath
Copy link
Contributor

Wow!!! This is fantastic! Wanna test this as soon as possible!!

@caphm
Copy link
Collaborator Author

caphm commented Nov 5, 2018

For everybody willing to test this, you can easily install this version from my repository: https://github.com/caphm/kodi-repo/raw/master/repository.kodi-repo-caphm/repository.kodi-repo-caphm-1.0.0.zip

Please make sure to do a backup of at least your library exports folders. This version uses some new storage formats, for which I have not yet fully implemented migration logic (still to come though).

@joaosagrath
Copy link
Contributor

OHH this is awesome, I will test om my work machine. Thanks caphm!

@hawkeyexp
Copy link
Collaborator

Wow a really big part of work! Currently now testing on my RPI3b+ - sometimes i noticed timeouts from addon signals - seems to be caused by the downloads of artwork on first enter the tv show list etc which needs more time than the failsave allows before the warning...

@hawkeyexp
Copy link
Collaborator

It seems library export is broken - my destination is located on a nfs which results in a read only fs fail (but it's rw and working on another mashine with plugin 13.x) - possible a rework with the xbmcvfs handling ?
Also the before exported media is not listed - did you remove the export scan destination to rebuild the list?

@caphm
Copy link
Collaborator Author

caphm commented Nov 5, 2018

@hawkeyexp Artwork downloads are handled by Kodi after the video listing has been built. This must be due to raw API operation. Timeouts can be caused by two things:

  1. The Netflix API takes unusually long to respond (timing information is in the logs, look for Request took XX.XXs)
  2. The post processing of the API response takes too long: Raw API responses are converted into more manageable data types (see api/data_types.py). This could be a potential bottleneck, but in my tests it rarely took over 200ms, even with large responses.

What I have noticed is, that if there are many addons running alongside, performance may sometimes be severely impacted. This isn't much of an issue on my hardware (Core i5), but can certainly push low powered hardware to its knees.
One instance where this is especially noticeable, is if you are running ArtworkBeef and do an export of My List with more than a handful of items. Because ArtworkBeef kicks in as soon as there are new items added to the library, you can really see the performance drop in the speed at which the export is running.

@caphm
Copy link
Collaborator Author

caphm commented Nov 5, 2018

@hawkeyexp library export uses native os.open and not xbmcvfs. I'll rework that.
Listing of exported items is solely reliant on the contents of library.ndb2. Items exported with 0.13.x and earlier are not recognized. Before this goes into release, I'll add a migration routine that will convert existing exports to the new library format.

@hawkeyexp
Copy link
Collaborator

@caphm - ok perfect - i had a look inside but you can do it more easy cause the big reworks needs time to step in again :-)

PS: a solve of the merge conflicts would be great to prevent from manual fixes on merge :-)

@caphm
Copy link
Collaborator Author

caphm commented Nov 5, 2018

The conflicting changes currently in master can be overwritten when merging this PR. The features added by @liberty-developer have been incorporated into this PR.

@ians325
Copy link

ians325 commented Nov 5, 2018

Error Playback Input for argument "input" for "Encrypt" must be a string or a byte array.
One Both Movies and TV

https://pastebin.com/zaPV9M5V

@caphm
Copy link
Collaborator Author

caphm commented Nov 5, 2018

Error Playback Input for argument "input" for "Encrypt" must be a string or a byte array.
One Both Movies and TV

https://pastebin.com/zaPV9M5V

Should be fixed with latest commit. Updated version is also in the repo. Thanks for catching that! Unfortunately I cannot test on Android :(

@caphm
Copy link
Collaborator Author

caphm commented Nov 5, 2018

Code works :-) But a note: if script tries to remove a missing file it results in script abort - possible a file exist check would be a good prevention - i noticed on removing show from export.

Good catch, thanks! I added a try/catch. Unfortunately I don't know which exceptions xbmcvfs specifically raises, so everything will need to go into ugly broad excepts :(

@Essam315
Copy link

Essam315 commented Nov 5, 2018

The search is still broken when you search for some words like "last", the same problem here

#456

The fix from here solved this problem (with 0.13.15).

#477

@caphm
Copy link
Collaborator Author

caphm commented Nov 5, 2018

The search is still broken when you search for some words like "last", the same problem here

#456

The fix from here solved this problem.

#477

Are you sure you're using the 0.14.0 version? This fix should not apply here, because that particular snippet of code (or anything comparable) is no longer used anywhere within the codebase.
I have tested the search with the problematic search terms and it works fine, at least on my end.

@ASHJG
Copy link

ASHJG commented Nov 5, 2018

Profiles that are marked as a "child" seems to be broken, I only seem to get Genre, Recommendations All TV shows, All Movies, Search and Exported, all menu items however are then empty, i have 3 other profiles not marked as child and they appear correctly
kodi.log

@zag2me
Copy link

zag2me commented Nov 5, 2018

As reported in the thread on kodi official forums, i get this error on Nvidia Shield when trying to play any video.

"B2a_base64() argument 1 must be string or buffer not dict."

Debug log - https://paste.kodi.tv/iqayayoleg.kodi

@Essam315
Copy link

Essam315 commented Nov 5, 2018

The search is still broken when you search for some words like "last", the same problem here
#456
The fix from here solved this problem.
#477

Are you sure you're using the 0.14.0 version? This fix should not apply here, because that particular snippet of code (or anything comparable) is no longer used anywhere within the codebase.
I have tested the search with the problematic search terms and it works fine, at least on my end.

Yes, i'm using 0.14.0~beta4 now, and thanks for fixing the 40 episodes limit, it worked just great, the fix i have posted i used it before with 0.13.15 not 0.14.0.

https://github.com/caphm/plugin.video.netflix/tree/release/0.14.0

This is the error message which i get when i search for the word "last"

errorlast

I'm using windows 10 and this release from Kodi.

KodiSetup-20181102-d0a7c358-master-x86

Kodi log

https://pastebin.com/PEAuNR00

@ASHJG
Copy link

ASHJG commented Nov 5, 2018

I'm getting a "invalidpatherror: no root path to handler extrafanart" error message on my Nvidia Shield, i can not replicate this on my Windows Laptop though,

This happens pretty much as soon as I select a profile and navigate to a menu.

Extract from Log:

`23:38:04.917 T:204217500912    INFO: [plugin.video.netflix (11)] Started (Version 0.14.0~beta5)
23:38:04.918 T:204217500912    INFO: [plugin.video.netflix (11)] URL is ParseResult(scheme='plugin', netloc='plugin.video.netflix', path='/extrafanart/', params='', query='', fragment='')
23:38:04.918 T:204217500912   DEBUG: [plugin.video.netflix (11)] Routing navigation request
23:38:04.919 T:204217500912   ERROR: [plugin.video.netflix (11)] Traceback (most recent call last):
                                              File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/plugin.video.netflix/addon.py", line 85, in <module>
                                                route(filter(None, g.PATH.split('/')))
                                              File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/plugin.video.netflix/addon.py", line 49, in lazy_login_wrapper
                                                return func(*args, **kwargs)
                                              File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/plugin.video.netflix/addon.py", line 71, in route
                                                'No root handler for path {}'.format('/'.join(pathitems)))
                                            InvalidPathError: No root handler for path extrafanart
23:38:04.922 T:203905295600   DEBUG: ------ Window Init (DialogConfirm.xml) ------
23:38:04.922 T:203905295600    INFO: Loading skin file: DialogConfirm.xml, load type: KEEP_IN_MEMORY

full log from Nvidia Shield also attached:
kodi.log
`

@Essam315
Copy link

Essam315 commented Nov 5, 2018

Never mind, the search problem fixed in 0.14.0~beta5, thanks for your great work.

@ians325
Copy link

ians325 commented Nov 5, 2018

As reported in the thread on kodi official forums, i get this error on Nvidia Shield when trying to play any video.

"B2a_base64() argument 1 must be string or buffer not dict."

Im getting this to

https://paste.kodi.tv/ihukocubel.kodi

@caphm
Copy link
Collaborator Author

caphm commented Nov 6, 2018

Profiles that are marked as a "child" seems to be broken, I only seem to get Genre, Recommendations All TV shows, All Movies, Search and Exported, all menu items however are then empty, i have 3 other profiles not marked as child and they appear correctly
kodi.log

At least partially confirmed. Which lists are displayed depends on what returns from the API. If there are no lists returned, the items show up empty. I have had the same issue myself, another user that reported a different (now fixed) issue with kids profiles did receive somelists to display from the API. I'm not sure why Netflix does this... it happened once on a normal profile as well, but I haven't been able to reproduce. In any case, I'll keep this on the to do list for the future, but Kids profiles won't be a focus for this release.

As reported in the thread on kodi official forums, i get this error on Nvidia Shield when trying to play any video.

"B2a_base64() argument 1 must be string or buffer not dict."

Debug log - https://paste.kodi.tv/iqayayoleg.kodi

Fixed in beta6

Never mind, the search problem fixed in 0.14.0~beta5, thank you for great work.

There was another (new) issue with the search term "last", which I encountered and fixed in beta5. Thanks for the report though.

I'm getting a "invalidpatherror: no root path to handler extrafanart" error message on my Nvidia Shield, i can not replicate this on my Windows Laptop though,

This happens pretty much as soon as I select a profile and navigate to a menu.

Extract from Log:

`23:38:04.917 T:204217500912    INFO: [plugin.video.netflix (11)] Started (Version 0.14.0~beta5)
23:38:04.918 T:204217500912    INFO: [plugin.video.netflix (11)] URL is ParseResult(scheme='plugin', netloc='plugin.video.netflix', path='/extrafanart/', params='', query='', fragment='')
23:38:04.918 T:204217500912   DEBUG: [plugin.video.netflix (11)] Routing navigation request
23:38:04.919 T:204217500912   ERROR: [plugin.video.netflix (11)] Traceback (most recent call last):
                                              File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/plugin.video.netflix/addon.py", line 85, in <module>
                                                route(filter(None, g.PATH.split('/')))
                                              File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/plugin.video.netflix/addon.py", line 49, in lazy_login_wrapper
                                                return func(*args, **kwargs)
                                              File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/plugin.video.netflix/addon.py", line 71, in route
                                                'No root handler for path {}'.format('/'.join(pathitems)))
                                            InvalidPathError: No root handler for path extrafanart
23:38:04.922 T:203905295600   DEBUG: ------ Window Init (DialogConfirm.xml) ------
23:38:04.922 T:203905295600    INFO: Loading skin file: DialogConfirm.xml, load type: KEEP_IN_MEMORY

full log from Nvidia Shield also attached:
kodi.log
`

I don't know which addon is generating these stupid extrafanart invocations, but they are now being ignored in beta6 ;) This should be fixed.

@joaosagrath
Copy link
Contributor

joaosagrath commented Nov 6, 2018

Can't set the old string to widgets.

Before I used "plugin://plugin.video.netflix/?action=video_list&type=queue" to get My List as widgets.

Edit: Already found a solution to widgets: The string to widgets is now: "plugin://plugin.video.netflix/directory/video_list/queue/"

And remove an item from My List in the Netflix Website don't remove the item from kodi library, it work only if we remove the item inside the addon. It would be great if the addon identificates if an item are on list or not, because if some tv show/movie it removed from Netflix, it will be removed from kodi too!

Tv shows do not exported with seasons folders. All eps are exported inside a only one folder with the the show name without release year, this can causes wrong identification of the tv show from kodi.

Others things that I tested works fine!!!

@Dnkhatri
Copy link

Dnkhatri commented Mar 8, 2019

probably all versions of the plugin will not work anymore
netflix has changed the request string to get the menu list
I'll try to find a solution in the next few days

I think a fix for this just got a pull request
#642

@mattenklicker
Copy link

probably all versions of the plugin will not work anymore
netflix has changed the request string to get the menu list
I'll try to find a solution in the next few days

I think a fix for this just got a pull request
#642

Modified patch for @CastagnaIT's fork:

--- a/resources/lib/services/nfsession/nfsession.py 2019-03-08 18:31:45.531974969 +0100
+++ b/resources/lib/services/nfsession/nfsession.py 2019-03-08 18:32:41.446971876 +0100
@@ -314,9 +314,11 @@
             'Accept': 'application/json, text/javascript, */*'}
         params = {
             'model': self.session_data['user_data']['gpsModel']}
-        data = json.dumps({
-            'paths': paths,
-            'authURL': self.auth_url})
+        data = ""
+        for path in paths:
+            data = data + 'path=' + json.dumps(path) + '&'
+
+        data = data + 'authURL=' + self.auth_url
         return self._post(
             component='shakti',
             req_type='api',

@nolsen42
Copy link

nolsen42 commented Mar 9, 2019

Tried that patch, beta is still pretty much broken.

Videos won't even play. After cleaning my data directory, now I can't even login!

@nolsen42
Copy link

nolsen42 commented Mar 9, 2019

If it's not failing from login, it's failing from AddonSignals

                                              File "/storage/.kodi/addons/plugin.video.netflix/addon.py", line 89, in <module>
                                                route(filter(None, g.PATH.split('/')))
                                              File "/storage/.kodi/addons/plugin.video.netflix/addon.py", line 49, in lazy_login_wrapper
                                                return func(*args, **kwargs)
                                              File "/storage/.kodi/addons/plugin.video.netflix/addon.py", line 77, in route
                                                g.REQUEST_PARAMS)
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/navigation/__init__.py", line 21, in execute
                                                executor(pathitems=pathitems)
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/navigation/directory.py", line 38, in root
                                                self.profiles()
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/navigation/directory.py", line 44, in profiles
                                                listings.build_profiles_listing(api.profiles())
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/common/misc_utils.py", line 235, in timing_wrapper
                                                return func(*args, **kwargs)
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/api/shakti.py", line 64, in profiles
                                                return common.make_call('list_profiles')
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/common/misc_utils.py", line 235, in timing_wrapper
                                                return func(*args, **kwargs)
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/common/ipc.py", line 60, in make_call
                                                return make_addonsignals_call(callname, data)
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/common/ipc.py", line 96, in make_addonsignals_call
                                                raise Exception('AddonSignals call timed out')
                                            Exception: AddonSignals call timed out

@nolsen42
Copy link

nolsen42 commented Mar 9, 2019

The patch to fix the login is also broken when you enable IPC over HTTP, to workaround the AddonSignals timeout.

2019-03-08 22:31:15.064 T:1415046000   ERROR: [plugin.video.netflix (0)] Traceback (most recent call last):
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/common/ipc.py", line 119, in make_return_call
                                                result = call(instance, func, data)
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/common/ipc.py", line 141, in call
                                                return func(instance, data)
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/services/nfsession/nfsession.py", line 56, in ensure_login
                                                return func(*args, **kwargs)
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/services/nfsession/nfsession.py", line 258, in path_request
                                                return self._path_request(paths)
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/common/misc_utils.py", line 235, in timing_wrapper
                                                return func(*args, **kwargs)
                                              File "/storage/.kodi/addons/plugin.video.netflix/resources/lib/services/nfsession/nfsession.py", line 298, in _path_request
                                                data = data + 'authURL=' + self.user_data['authURL']
                                            AttributeError: 'NetflixSession' object has no attribute 'user_data'

@phyzical
Copy link

phyzical commented Mar 9, 2019

i haven't tried adding a new show.
but i was able to stream fine last night on windows beta 21 of the plugin.

Perhaps there is an unrelated issue here?

@nolsen42
Copy link

nolsen42 commented Mar 9, 2019

So I read the wrong commit and applied the wrong patch, the login works fine as far as I can tell, but video playback does not work at all.

"Unable to create context (due to ContentException)"

I tried with both IPC over HTTP enabled and disabled

@nolsen42
Copy link

nolsen42 commented Mar 9, 2019

Oh, so the problem was I needed beta20, everything works now.

@Dnkhatri
Copy link

Dnkhatri commented Mar 9, 2019

Oh, so the problem was I needed beta20, everything works now.

Beta 22 is the one with the latest patch. Are sure sure its beta 20 thats working. I just installed beta 22 over beta 20 and it started working again.

@nolsen42
Copy link

nolsen42 commented Mar 9, 2019

Oh, so the problem was I needed beta20, everything works now.

Beta 22 is the one with the latest patch. Are sure sure its beta 20 thats working. I just installed beta 22 over beta 20 and it started working again.

Yeah I'm using Beta22

@mac1202
Copy link

mac1202 commented Mar 9, 2019

Hi, @CastagnaIT I got a issue with the latest master branch. I can play movie and tv show that are already exported to my library. But I cannot browse any folder from the addon it throw me an error everytime.
here the log https://paste.ubuntu.com/p/7rV5n8NzVZ/

@chewvodka
Copy link

Sorry for still being kind of a newb to Github.. where can I find the latest build everybody is testing? Rather than giving me a direct link, can somebody explain how to find it?

@debutanker
Copy link

@chewvodka
Copy link

chewvodka commented Mar 9, 2019

Thanks, hopefully this will help other people too. So, should be we commenting on THAT github then rather than this one?


Looks like its still not working. I installed the new version over the existing. It said an updated to Wildvine was needed. Installed that, then the video I picked played. Yay! Then I rebooted. It looks like I can still log in, but every 30 seconds or so I get an error Exception: HTTPError.
Running on Raspberry Pi 3 / LibreElec 9.0.0

I'm going to try uninstalling it and reinsalling it.


That broke it even more. Now I can't even log in. Keeps saying to check credentials.

@chewvodka
Copy link

Looks like the latest version is working 20190308build2. I still get the occasional popup about keyfile or addonsignals, etc. But looks good. I was able to login without a constant "check credentials" error, and I could view My List and watch stuff. Downstairs my Dad was able to login with his profile, view his list, and watch something. Looks like it's a good start.

@jakermx
Copy link

jakermx commented Mar 25, 2019

Hello there,
I would like to apologize for my dissaper, i have had very difficult times, but Last week I had a surgery that is very hopefully.
I almost lost my left hand, but now I will have it, not at 100% but at least I will have it at 60% but ast most at 75%.
I have to have at least 2 more surgeries, but not in a near futrure but so far I will be back posting and supporting soon.

Cheers from Mexico!

@CastagnaIT
Copy link

@jakermx I'm very very sorry good man, and i wish you a good recovery.

But i suggest you to delete these photos, this is not a forum, here are accepted discussions only for development purposes, we risk warnings from github...

@chewvodka
Copy link

@jakermx - Ouch! I had a surgery in November that took my gall bladder out. Then in January I had a mesh put in to resolve a hernia. Recovery is no joke, but you'll get there eventually! Take your time, take it slow, and don't feel like you need to get back into it right away! Hope you feel better soon. :)

@MartChic
Copy link

@chewvodka
https://github.com/CastagnaIT/plugin.video.netflix or
https://m.mediafire.com/folder/tnu4623j66c66

Many thx at this point to CastagnaIT!

What is the correct way to install those zip files? Thanks!

@chewvodka
Copy link

What is the correct way to install those zip files? Thanks!

Download the zip. Put it on your device. Inside Kodi go to Settings -> Addons -> Install from Zip -> Navigate to and select the Zip you put on the device. This installs it.

@MartChic
Copy link

What is the correct way to install those zip files? Thanks!

Download the zip. Put it on your device. Inside Kodi go to Settings -> Addons -> Install from Zip -> Navigate to and select the Zip you put on the device. This installs it.

Thanks! Do I have to uninstall older versions first?

@MartChic
Copy link

I tried the latest beta and latest nightly build and both don't work. Here is the part of the log file that seems relevant. Any idea?

2019-03-26 22:22:46.127 T:1677550320 ERROR: [plugin.video.netflix (0)] IPC callback raised exception: 2019-03-26 22:22:46.128 T:1677550320 ERROR: [plugin.video.netflix (0)] Traceback (most recent call last): File "/home/pi/.kodi/addons/plugin.video.netflix/resources/lib/common/ipc.py", line 119, in make_return_call result = call(instance, func, data) File "/home/pi/.kodi/addons/plugin.video.netflix/resources/lib/common/ipc.py", line 142, in call return func(instance) File "/home/pi/.kodi/addons/plugin.video.netflix/resources/lib/services/nfsession/nfsession.py", line 193, in login self._login() File "/home/pi/.kodi/addons/plugin.video.netflix/resources/lib/common/misc_utils.py", line 235, in timing_wrapper return func(*args, **kwargs) File "/home/pi/.kodi/addons/plugin.video.netflix/resources/lib/services/nfsession/nfsession.py", line 209, in _login raise LoginFailedError LoginFailedError 2019-03-26 22:22:46.211 T:1527747312 ERROR: [plugin.video.netflix (1)] IPC call login returned LoginFailedError: 2019-03-26 22:22:46.212 T:1774187248 ERROR: GetDirectory - Error getting plugin://plugin.video.netflix/ 2019-03-26 22:22:46.212 T:1527747312 WARNING: Attempt to use invalid handle 1 2019-03-26 22:22:46.213 T:1899891984 ERROR: CGUIMediaWindow::GetDirectory(plugin://plugin.video.netflix/) failed 2019-03-26 22:23:03.275 T:1899891984 NOTICE: stop player 2019-03-26 22:23:03.275 T:1899891984 NOTICE: Storing total System Uptime 2019-03-26 22:23:03.275 T:1899891984 NOTICE: Saving settings 2019-03-26 22:23:03.283 T:1899891984 NOTICE: Saving skin settings 2019-03-26 22:23:03.285 T:1899891984 NOTICE: stop all 2019-03-26 22:23:03.285 T:1899891984 NOTICE: ES: Stopping event server 2019-03-26 22:23:03.285 T:1899891984 NOTICE: stopping zeroconf publishing 2019-03-26 22:23:03.289 T:1899891984 NOTICE: CWebServer[8080]: Stopped 2019-03-26 22:23:03.434 T:1635586800 NOTICE: ES: UDP Event server stopped 2019-03-26 22:23:03.435 T:1899891984 NOTICE: stop dvd detect media

@jakermx
Copy link

jakermx commented Mar 29, 2019

What is the correct way to install those zip files? Thanks!

Download the zip. Put it on your device. Inside Kodi go to Settings -> Addons -> Install from Zip -> Navigate to and select the Zip you put on the device. This installs it.

Thanks! Do I have to uninstall older versions first?

Yes, Uninstall it, Disable Add AutoUpdates, Reboot, Install from ZIP, Not needed but I recommend to restart before first use.

I just made a LibreElec clean install and I just had an issue with AddOnSignals, so I enabled IPC and viola!!

@cpetry
Copy link

cpetry commented May 19, 2019

How is the progress on this pull request?
I assume many would like to update the regular way

@Dnkhatri
Copy link

How is the progress on this pull request?
I assume many would like to update the regular way

it is already being updated the regular way just install the new repo this repository has mostly been abandoned.
https://github.com/CastagnaIT/plugin.video.netflix

@cpetry
Copy link

cpetry commented May 20, 2019

Ah, many thanks for the info!
Didn't see anything about that.

@the-dreamer
Copy link

I have raised this question on kodinerds.net. Caphm is not available at the Moment. Thankfully others have continue the work. But that is Not a reason to have a New fork. In my point of view this repo is still active as we could See last changes by netflix 1,5 monts ago. V13,x is still working fine. We only need a New pull request.

But if the repo owner don't want to continue we need to change of course.

@jakermx
Copy link

jakermx commented Jun 19, 2019

I tried the latest beta and latest nightly build and both don't work. Here is the part of the log file that seems relevant. Any idea?

2019-03-26 22:22:46.127 T:1677550320 ERROR: [plugin.video.netflix (0)] IPC callback raised exception: 2019-03-26 22:22:46.128 T:1677550320 ERROR: [plugin.video.netflix (0)] Traceback (most recent call last): File "/home/pi/.kodi/addons/plugin.video.netflix/resources/lib/common/ipc.py", line 119, in make_return_call result = call(instance, func, data) File "/home/pi/.kodi/addons/plugin.video.netflix/resources/lib/common/ipc.py", line 142, in call return func(instance) File "/home/pi/.kodi/addons/plugin.video.netflix/resources/lib/services/nfsession/nfsession.py", line 193, in login self._login() File "/home/pi/.kodi/addons/plugin.video.netflix/resources/lib/common/misc_utils.py", line 235, in timing_wrapper return func(*args, **kwargs) File "/home/pi/.kodi/addons/plugin.video.netflix/resources/lib/services/nfsession/nfsession.py", line 209, in _login raise LoginFailedError LoginFailedError 2019-03-26 22:22:46.211 T:1527747312 ERROR: [plugin.video.netflix (1)] IPC call login returned LoginFailedError: 2019-03-26 22:22:46.212 T:1774187248 ERROR: GetDirectory - Error getting plugin://plugin.video.netflix/ 2019-03-26 22:22:46.212 T:1527747312 WARNING: Attempt to use invalid handle 1 2019-03-26 22:22:46.213 T:1899891984 ERROR: CGUIMediaWindow::GetDirectory(plugin://plugin.video.netflix/) failed 2019-03-26 22:23:03.275 T:1899891984 NOTICE: stop player 2019-03-26 22:23:03.275 T:1899891984 NOTICE: Storing total System Uptime 2019-03-26 22:23:03.275 T:1899891984 NOTICE: Saving settings 2019-03-26 22:23:03.283 T:1899891984 NOTICE: Saving skin settings 2019-03-26 22:23:03.285 T:1899891984 NOTICE: stop all 2019-03-26 22:23:03.285 T:1899891984 NOTICE: ES: Stopping event server 2019-03-26 22:23:03.285 T:1899891984 NOTICE: stopping zeroconf publishing 2019-03-26 22:23:03.289 T:1899891984 NOTICE: CWebServer[8080]: Stopped 2019-03-26 22:23:03.434 T:1635586800 NOTICE: ES: UDP Event server stopped 2019-03-26 22:23:03.435 T:1899891984 NOTICE: stop dvd detect media

I got that issue today, the models API_BASE_URL its gone, so I modifyed website.py and nfsession.py pointing to the new model element called apiUrl, look at @CastagnaIT issues section for my workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment