New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solves issue 94 #95
Merged
Merged
Solves issue 94 #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tets are now parallel, but at the cost of lost coberture, because are running in a different JVM, for the moment.
…. Reflected in .travis.yml
…and other minor fixes
Codacy mirrors the Maven Central Repository, and I could not find a way to disable the mirror. So I left only one line log check.
Codacy doesn't detect the method specified by @MethodSource. May be converting it to public (instead of private) the warning will dissapear.
This changes adds the asciidoctor-verify phase invoked after the asciidoctor-post-publish phase. This phase was sugested By @abelsromero. This commit resolves asciidoctor-lifecycle-maven#68.
CopySources is a more descriptive name about its tasks.
Here is an overview of what got changed by this pull request: Complexity increasing per file
==============================
- src/test/java/com/coutemeier/maven/plugins/asciidoctor/lifecycle/vo/MyFile.java 1
- src/test/java/com/coutemeier/maven/plugins/asciidoctor/lifecycle/PublishToUnsupportedProtocolsIT.java 1
- src/main/java/com/coutemeier/maven/plugins/asciidoctor/lifecycle/CopySourcesMojo.java 4
- src/test/java/com/coutemeier/maven/plugins/asciidoctor/lifecycle/AbstractWebdavPublishMojoIT.java 2
- src/test/java/com/coutemeier/maven/plugins/asciidoctor/lifecycle/PublishToWebdavWithCredentialsIT.java 1
- src/test/java/com/coutemeier/maven/plugins/asciidoctor/lifecycle/PublishToHttpsIT.java 1
- src/test/java/com/coutemeier/maven/plugins/asciidoctor/lifecycle/AbstractPublishMojoIT.java 1
- src/test/java/com/coutemeier/maven/plugins/asciidoctor/lifecycle/PublishToDirectoryIT.java 1
- src/test/java/com/coutemeier/maven/plugins/asciidoctor/lifecycle/PublishToWebdavWithWrongCredentialsIT.java 1
- src/test/java/com/coutemeier/maven/plugins/asciidoctor/lifecycle/PublishToWebdavWithoutCredentialsIT.java 1
- src/test/java/com/coutemeier/maven/plugins/asciidoctor/lifecycle/webdav/SimpleDavServer.java 3
- src/test/java/com/coutemeier/maven/plugins/asciidoctor/lifecycle/CopySourcesIT.java 1
- src/test/java/com/coutemeier/maven/plugins/asciidoctor/lifecycle/vo/ProjectValidator.java 2
Complexity decreasing per file
==============================
+ src/main/java/com/coutemeier/maven/plugins/asciidoctor/lifecycle/util/ZipUtil.java -1
+ src/main/java/com/coutemeier/maven/plugins/asciidoctor/lifecycle/util/WagonUtil.java -2
See the complete overview on Codacy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #94