Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solves issue 94 #95

Merged
merged 11 commits into from Oct 8, 2020
Merged

Solves issue 94 #95

merged 11 commits into from Oct 8, 2020

Conversation

rrialq
Copy link
Member

@rrialq rrialq commented Oct 3, 2020

Solves #94

  • Unit tests updated to JUnit5.
  • Integration tests updated to JUnit5 and Integration Test Framework.

Tets are now parallel, but at the cost of lost coberture, because are running in a different JVM, for the moment.
Codacy mirrors the Maven Central Repository, and I could not find a way to disable the mirror.
So I left only one line log check.
Codacy doesn't detect the method specified by @MethodSource.
May be converting it to public (instead of private) the warning will dissapear.
This changes adds the asciidoctor-verify phase invoked after the asciidoctor-post-publish phase.
This phase was sugested By @abelsromero.

This commit resolves asciidoctor-lifecycle-maven#68.
CopySources is a more descriptive name about its tasks.
Copy link
Member Author

rrialq commented Oct 8, 2020

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- src/test/java/com/coutemeier/maven/plugins/asciidoctor/lifecycle/vo/MyFile.java  1
- src/test/java/com/coutemeier/maven/plugins/asciidoctor/lifecycle/PublishToUnsupportedProtocolsIT.java  1
- src/main/java/com/coutemeier/maven/plugins/asciidoctor/lifecycle/CopySourcesMojo.java  4
- src/test/java/com/coutemeier/maven/plugins/asciidoctor/lifecycle/AbstractWebdavPublishMojoIT.java  2
- src/test/java/com/coutemeier/maven/plugins/asciidoctor/lifecycle/PublishToWebdavWithCredentialsIT.java  1
- src/test/java/com/coutemeier/maven/plugins/asciidoctor/lifecycle/PublishToHttpsIT.java  1
- src/test/java/com/coutemeier/maven/plugins/asciidoctor/lifecycle/AbstractPublishMojoIT.java  1
- src/test/java/com/coutemeier/maven/plugins/asciidoctor/lifecycle/PublishToDirectoryIT.java  1
- src/test/java/com/coutemeier/maven/plugins/asciidoctor/lifecycle/PublishToWebdavWithWrongCredentialsIT.java  1
- src/test/java/com/coutemeier/maven/plugins/asciidoctor/lifecycle/PublishToWebdavWithoutCredentialsIT.java  1
- src/test/java/com/coutemeier/maven/plugins/asciidoctor/lifecycle/webdav/SimpleDavServer.java  3
- src/test/java/com/coutemeier/maven/plugins/asciidoctor/lifecycle/CopySourcesIT.java  1
- src/test/java/com/coutemeier/maven/plugins/asciidoctor/lifecycle/vo/ProjectValidator.java  2
         

Complexity decreasing per file
==============================
+ src/main/java/com/coutemeier/maven/plugins/asciidoctor/lifecycle/util/ZipUtil.java  -1
+ src/main/java/com/coutemeier/maven/plugins/asciidoctor/lifecycle/util/WagonUtil.java  -2
         

See the complete overview on Codacy

@rrialq rrialq merged commit 41e7199 into asciidoctor-lifecycle-maven:master Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant