-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add named routes with bespoke-hash? #9
Comments
We are waiting on bespokejs/bespoke-hash#4 to be merged upstream. Then you can just write:
And it will work. Of course, I'm now maintainer on Bespoke, so I guess I can approve that PR now. Would you like to test it? |
@cexbrayat Do you think we should just fix this in bespoke-hash instead? I don't really love the idea of adding a hash attribute to the section. But I can be swayed. |
Well, even better than what I was trying to come with :) Sure, ping me when it's testable, I'll gladly give it a go. |
Can you test the open PR? bespokejs/bespoke-hash#4 |
I just did, and it works great 👍 |
\o/ Do you see any reason why we wouldn't want to base the association on the ID? (I can't really think of any). |
TBH that was what I tried first without looking at the docs, so I think it would be the way to go :) |
@mojavelinux I added a PR to document that (if it ever gets merged upstream :) ) |
That's exactly what we like to hear before merging a feature. 👍 |
I just tested Thanks @mojavelinux and @hsablonniere for your (as always) quick and very nice help! |
Our pleasure! We love saving good people valuable time. 🍺
|
Sorry if this is obvious, but I can't figure out how to use name route hashes provided by https://github.com/bespokejs/bespoke-hash with
asciidoctor-bespoke
...If I understand https://github.com/asciidoctor/asciidoctor-bespoke/blob/master/templates/slim/section.html.slim this might not yet be supported (it doesn't look like
data-bespoke-hash
can be added to the section.Something like:
allowing to go to
/#intro
would be great.If you agree (and if it isn't yet supported), I can provide a naive PR to implement it.
The text was updated successfully, but these errors were encountered: