Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROPOSED] Replace ERD (Haskell) with erd-go #402

Closed
barthel opened this issue Mar 21, 2023 · 8 comments
Closed

[PROPOSED] Replace ERD (Haskell) with erd-go #402

barthel opened this issue Mar 21, 2023 · 8 comments

Comments

@barthel
Copy link

barthel commented Mar 21, 2023

As part of asciidoctor/docker-asciidoctor#51 I have been trying to create a multi-platform Asciidoctor Docker image.

In doing so, erd (https://github.com/BurntSushi/erd) was a challenge, as there is only one x86 platform variant.

To remove this limitation, I looked at erd-go (https://github.com/kaishuu0123/erd-go/) and included it.
Since it supports the same CLI parameters, replacing the executable was enough.

To further promote platform independence, I would like to propose an official switch to or support of erd-go.

@barthel
Copy link
Author

barthel commented Mar 21, 2023

erd was introduced with #118

@barthel barthel changed the title [PROPOSED] Replace erd (Haskell) with erd-go [PROPOSED] Replace ERD (Haskell) with erd-go Mar 21, 2023
@barthel
Copy link
Author

barthel commented Mar 21, 2023

WDYT? @pepijnve @mojavelinux

pepijnve added a commit that referenced this issue Mar 21, 2023
@pepijnve
Copy link
Member

That makes a whole lot of sense. Should simplify (and significantly shorten) the CI builds as well. Installing the Haskell environment eats up a lot of time just for erd. Referenced PR should make this work already.

@barthel
Copy link
Author

barthel commented Mar 21, 2023

Used and testable via Docker Image https://hub.docker.com/r/uwebarthel/asciidoctor/

Github project (Dockerfile): https://github.com/barthel/docker-asciidoctor

@dduportal
Copy link

Hello folks, sorry for being a party crasher bu you might want to look at asciidoctor/docker-asciidoctor#343 (comment) .

It is hard to evaluate the safety of erd-go as it has not been updated since Feb. 2021, before the Travis credentials leaks.
If at least we can help the author by switching their CI to GitHub Actions and have a new release fully from GitHub, that would be a first trustable step.
Eventually forking the repository to asciidoctor (if someone agrees to maintain it)?

A cleanup of the golang version and its gomod version (dependabot) would also clearly help.

@barthel Are you up to the challenge?

@pepijnve
Copy link
Member

@dduportal I understand the concern. Not really an issue for the diagram extension itself since it supports both the Haskell and Go version now preferring the former over the latter.

@barthel
Copy link
Author

barthel commented Mar 24, 2023

@dduportal You are not a party chrasher. Security concerns are important and valid at any time.

The goal of using erd-go is to use a platform independend tool.
As a consequence, erd-go will be compiled for each platform and no pre-compiled executables are used.

Let's discuss in asciidoctor/docker-asciidoctor#343 (comment)

@barthel
Copy link
Author

barthel commented Mar 24, 2023

Challange accepted for a more than less platform independent Asciidoctor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants