Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating an inline barcode logs an info message #416

Closed
ahus1 opened this issue Jun 11, 2023 · 3 comments
Closed

Creating an inline barcode logs an info message #416

ahus1 opened this issue Jun 11, 2023 · 3 comments

Comments

@ahus1
Copy link
Contributor

ahus1 commented Jun 11, 2023

Given the following input

qrcode:https://my-link.tld/something[]

and rendering it with INFO messages enabled (-v)

asciidoctor -r asciidoctor-diagram test.adoc -v

there is a INFO message indicating a possible problem:

asciidoctor: INFO: expected substitution value for custom inline macro to be of type Inline; got String: qrcode:https://my-link.tld/something[]

This only occurs with the inline macro, not with the block macro.

@ahus1
Copy link
Contributor Author

ahus1 commented Jun 11, 2023

Might be related to this - the following code:

qrcode:https://my-link.tld/something[format=txt]

creates this error message:

asciidoctor: ERROR: test.adoc: line 3: Failed to generate image: Asciidoctor::Diagram::BarcodeInlineMacroProcessor does not support output format txt
undefined method `include?' for nil:NilClass

@pepijnve
Copy link
Member

Looks like I got that wrong when I added inline support. The processor was eagerly converting the Inline node instead of returning it.

@mojavelinux
Copy link
Member

That used it be how it was, but it changed in Asciidoctor 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants