#416 Don't eagerly convert Inline nodes during processing

asciidoctor · Jun 12, 2023 · 372a3f9 · 372a3f9
1 parent 0a52fe3
commit 372a3f9
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/CHANGELOG.adoc b/CHANGELOG.adoc
@@ -1,5 +1,11 @@
 = Asciidoctor-diagram Changelog
 
+== 2.2.10
+
+Bugfixes::
+
+* Issue #416: Silence Asciidoctor warning when using inline macros
+
 == 2.2.9
 
 Bugfixes::

diff --git a/lib/asciidoctor-diagram/diagram_processor.rb b/lib/asciidoctor-diagram/diagram_processor.rb
@@ -423,7 +423,7 @@ def process(parent, reader_or_target, attributes)
         block = generate_block(parent, reader_or_target, attributes)
         attrs = block.attributes.dup
         target = attrs.delete('target')
-        create_inline(parent, :image, nil, :type => 'image', :target => target, :attributes => attrs).convert
+        create_inline(parent, :image, nil, :type => 'image', :target => target, :attributes => attrs)
       end
 
       def supported_formats(converter)

diff --git a/spec/test_helper_methods.rb b/spec/test_helper_methods.rb
@@ -47,6 +47,8 @@ def find(&block)
 module Asciidoctor
   module Diagram
     module TestHelpers
+      include ::Asciidoctor::Logging
+
       def load_asciidoc(source, options = {})
         options = options.dup
         options[:trace] = true
@@ -71,7 +73,8 @@ def load_asciidoc(source, options = {})
           options[:attributes]['diagram-on-error'] = 'abort'
         end
 
-        ::Asciidoctor.load(StringIO.new(source), options.merge({:trace => true}))
+        logger.level = ::Logger::Severity::DEBUG
+        ::Asciidoctor.load(StringIO.new(source), options.merge({:trace => true, :verbose => 2}))
       end
     end
   end