Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy files starting with underscores when using intermediate working directory #410

Closed
ysb33r opened this issue Jun 23, 2019 · 1 comment
Closed

Copy files starting with underscores when using intermediate working directory #410

ysb33r opened this issue Jun 23, 2019 · 1 comment
Labels
2.x Issue related to the 2.x series 3.x Issues related to the 3.x bug

Comments

@ysb33r
Copy link
Member

ysb33r commented Jun 23, 2019

No description provided.

@ysb33r ysb33r added bug 2.x Issue related to the 2.x series 3.x Issues related to the 3.x labels Jun 23, 2019
@ysb33r ysb33r mentioned this issue Jun 23, 2019
Closed
ysb33r added a commit to ysb33r/asciidoctor-gradle-plugin that referenced this issue Jun 30, 2019
@ysb33r
Treat underscore-led asciidoc patterns as secondary sources (asciidoc…
2fa0129 
…tor#410)
ysb33r added a commit to ysb33r/asciidoctor-gradle-plugin that referenced this issue Jun 30, 2019
@ysb33r
Treat underscore-led asciidoc patterns as secondary sources (asciidoc…
695f17b 
…tor#410)
ysb33r added a commit to ysb33r/asciidoctor-gradle-plugin that referenced this issue Jun 30, 2019
@ysb33r
Treat underscore-led asciidoc patterns as secondary sources (asciidoc…
0bd1998 
…tor#410)
ysb33r added a commit to ysb33r/asciidoctor-gradle-plugin that referenced this issue Jun 30, 2019
@ysb33r
Treat underscore-led asciidoc patterns as secondary sources (asciidoc…
139f790 
…tor#410)
ysb33r added a commit to ysb33r/asciidoctor-gradle-plugin that referenced this issue Jun 30, 2019
@ysb33r
Treat underscore-led asciidoc patterns as secondary sources (asciidoc…
7224469 
…tor#410)
ysb33r added a commit to ysb33r/asciidoctor-gradle-plugin that referenced this issue Jul 3, 2019
@ysb33r
Add underscore-led Asciidoc files to secondary source patterns (ascii…
29b10ab 
…doctor#410)
ysb33r added a commit that referenced this issue Jul 4, 2019
@ysb33r
Merge pull request #427 from ysb33r/underscores-410-2.x
edb1c4b 
Add underscore-led Asciidoc files to secondary source patterns (#410)
@ysb33r ysb33r mentioned this issue Jul 4, 2019
Merged
@ysb33r
Copy link
Member Author

ysb33r commented Jul 4, 2019

Will be in 2.3.0 and 3.0.0-alpha.4

@ysb33r ysb33r closed this as completed Jul 4, 2019
ysb33r added a commit to ysb33r/asciidoctor-gradle-plugin that referenced this issue Jul 8, 2019
@ysb33r
Exlude secondary source elements by matching rather than substraction (…
a38b986 
…asciidoctor#410)

This is a very subtle issue. When two Filtree instances are subtracted from each other
in order to eliminate a set of files, the base directory of the tree is lost. If this is
in a CopySpec the relative paths will thus also be lost. The solution is to use a matcher
of type PatternFilterable and then to exclude by FileTreeElement.

When using
@ysb33r ysb33r mentioned this issue Jul 8, 2019
Merged
ysb33r added a commit to ysb33r/asciidoctor-gradle-plugin that referenced this issue Jan 18, 2020
@ysb33r
Treat underscore-led asciidoc patterns as secondary sources (asciidoc…
2ad763d 
…tor#410)
ysb33r added a commit to ysb33r/asciidoctor-gradle-plugin that referenced this issue Jan 18, 2020
@ysb33r
Exlude secondary source elements by matching rather than substraction (…
3e49861 
…asciidoctor#410)

This is a very subtle issue. When two Filtree instances are subtracted from each other
in order to eliminate a set of files, the base directory of the tree is lost. If this is
in a CopySpec the relative paths will thus also be lost. The solution is to use a matcher
of type PatternFilterable and then to exclude by FileTreeElement.

When using
ysb33r added a commit to ysb33r/asciidoctor-gradle-plugin that referenced this issue Jan 19, 2020
@ysb33r
Treat underscore-led asciidoc patterns as secondary sources (asciidoc…
d43ab42 
…tor#410)
ysb33r added a commit to ysb33r/asciidoctor-gradle-plugin that referenced this issue Jan 19, 2020
@ysb33r
Exlude secondary source elements by matching rather than substraction (…
ddf77fd 
…asciidoctor#410)

This is a very subtle issue. When two Filtree instances are subtracted from each other
in order to eliminate a set of files, the base directory of the tree is lost. If this is
in a CopySpec the relative paths will thus also be lost. The solution is to use a matcher
of type PatternFilterable and then to exclude by FileTreeElement.

When using
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.x Issue related to the 2.x series 3.x Issues related to the 3.x bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ysb33r