Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse comment blocks; support "comment with line/block comment" actions #79

Merged
merged 2 commits into from
Jul 27, 2015

Conversation

yole
Copy link
Contributor

@yole yole commented Jul 27, 2015

No description provided.

bodiam added a commit that referenced this pull request Jul 27, 2015
Parse comment blocks; support "comment with line/block comment" actions
@bodiam bodiam merged commit 2a4c5e4 into asciidoctor:master Jul 27, 2015
@bodiam
Copy link
Contributor

bodiam commented Jul 27, 2015

Super! Question: would it also be possible to add support for bold? I can add the others for that.

@yole
Copy link
Contributor Author

yole commented Jul 27, 2015

I'm not yet sure what would be the best way to support inline markup.

@bodiam
Copy link
Contributor

bodiam commented Jul 27, 2015

Ah, it's more complex than just defining a pattern in the Lexer? Would something like this help by @valich: https://github.com/valich/intellij-markdown/blob/master/src/org/intellij/markdown/lexer/markdown.flex ?

update: ah, apparently not, since you are already contributing to that repository..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants