-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency to oss-parent and copy to local pom.xml #341
Conversation
32d6f72
to
a8da022
Compare
a8da022
to
8c5a3f5
Compare
1 similar comment
Looked into this and I think we can totally remove the parent. After all we are publishing through jcenter. |
Yes, we can remove parent-pom, but we should include all that was defined here. |
I totally agree with that to be safe. But I think we can go a bit further ;) The oss-parent I am ok with going ahead and seeing if we can simplify later. But wdyt, do we take our change now? |
I'm completely in support of this change. There was a time when that parent made sense. That time has passed. So this is really just residue from an old setup. |
462bd64
to
14b0297
Compare
Remove inherited and not used sonatype-oss-release profile
14b0297
to
3bca275
Compare
Ok, i've removed redundant sonatype-oss-release profile and snapshot repository. |
First - remove only parent-pom.
Next, i will add selected plugin updates from #337
cc: @khmarbaise could You help with validation?