Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency to oss-parent and copy to local pom.xml #341

Merged
merged 2 commits into from
Feb 18, 2018

Conversation

slachiewicz
Copy link
Contributor

First - remove only parent-pom.
Next, i will add selected plugin updates from #337

cc: @khmarbaise could You help with validation?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.005% when pulling 8c5a3f5 on slachiewicz:feature/340 into abbce69 on asciidoctor:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.005% when pulling 8c5a3f5 on slachiewicz:feature/340 into abbce69 on asciidoctor:master.

@coveralls
Copy link

coveralls commented Feb 11, 2018

Coverage Status

Coverage remained the same at 66.005% when pulling 3bca275 on slachiewicz:feature/340 into abbce69 on asciidoctor:master.

@abelsromero
Copy link
Member

Looked into this and I think we can totally remove the parent. After all we are publishing through jcenter.

@slachiewicz
Copy link
Contributor Author

Yes, we can remove parent-pom, but we should include all that was defined here.
I try to compare effective pom (mvn help:effective-pom) before, and after patch and looks equal.
Later you can remove a reduntant entries

@abelsromero
Copy link
Member

Yes, we can remove parent-pom, but we should include all that was defined here.

I totally agree with that to be safe. But I think we can go a bit further ;)

The oss-parent maven-release-plugin adds the sonatype-oss-release profile which overwrites source, javadoc and gpg plugins. But those are already defined, and honestly the options the oss build sets seem to be outdated to me.

I am ok with going ahead and seeing if we can simplify later. But wdyt, do we take our change now?

@mojavelinux
Copy link
Member

I'm completely in support of this change. There was a time when that parent made sense. That time has passed. So this is really just residue from an old setup.

@slachiewicz slachiewicz force-pushed the feature/340 branch 2 times, most recently from 462bd64 to 14b0297 Compare February 18, 2018 14:10
Remove inherited and not used sonatype-oss-release profile
@slachiewicz
Copy link
Contributor Author

Ok, i've removed redundant sonatype-oss-release profile and snapshot repository.
It was good for me to check how deployment to jcenter works - thx :)
After squash - I think all should be ready now for merge.

@abelsromero abelsromero merged commit 48a7afa into asciidoctor:master Feb 18, 2018
@slachiewicz slachiewicz deleted the feature/340 branch February 18, 2018 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants