Remove ambiguity in usage of maven properties docs #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsromero
force-pushed
the
docs/improve-maven-properties-usage
branch
from
6721e7a
to
e755ea2
Compare
abelsromero
force-pushed
the
docs/improve-maven-properties-usage
branch
from
e755ea2
to
ad9c325
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!
What kind of change does this PR introduce? (check at least one)
What is the goal of this pull request?
Improve docs about usage of Maven properties.
Now it should be more clear that now only properties set in the pom are passed as attributes.
Are there any alternative ways to implement this?
Explanation could be extended to explicitely state that Maven Model are NOT set. But for now I'd like to keep it simple.
Also, the text is duplu
Are there any implications of this pull request? Anything a user must know?
Need to refresh general docs site.
Is it related to an existing issue?
Finally, please add a corresponding entry to CHANGELOG.adoc