Skip to content

Commit

Permalink
Remove ambiguity in usage of maven properties docs
Browse files Browse the repository at this point in the history
  • Loading branch information
abelsromero committed Jan 2, 2021
1 parent 865c4d8 commit ad9c325
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ For a detailed view of what has changed, refer to the {uri-repo}/commits/master[
Documentation::

* Migrate docs (README) to Antora site and publish them in gh-pages (#498)
* Remove ambiguity in usage of maven properties docs (#507)

== v2.1.0 (2020-09-15)

Expand Down Expand Up @@ -53,4 +54,4 @@ Build / Infrastructure::
* Updated jacoco-maven-plugin version from v0.8.2 to 0.8.5 (#479)
* Use maven-javadoc-plugin version defined in `pluginManagement` + update to v3.2.0 (#481)
* Add Maven Wrapper to project and CI builds (#484)
* Upgrade Asciidoctorj to 2.4.1 ad jRuby to 9.2.13.0 (#486)
* Upgrade Asciidoctorj to 2.4.1 ad jRuby to 9.2.13.0 (#486)
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,8 @@ Refer to the http://asciidoctor.org/docs/user-manual/#attribute-catalog[catalog
<source-highlighter>coderay</source-highlighter>
</attributes>
----
In addition to those attributes found in this section, any Maven property is also passed as attribute (replacing . by -).
In addition to attributes set in this section, Maven properties are also passed as attribute (replacing . by - in the name).
These include those defined in the `<properties>` section of the project, parent projects and the user's `settings.xml`.
+
[source,xml]
----
Expand Down
3 changes: 2 additions & 1 deletion docs/modules/site-integration/pages/index.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,8 @@ Specifies additional Ruby libraries not packaged in AsciidoctorJ, `empty` by def
attributes::
Similar to the plugin's `attributes`. +
Allows defining a set of Asciidoctor attributes to be passed to the conversion. +
In addition to those attributes found in this section, any Maven property is also passed as attribute (replacing . by -).
In addition to attributes set in this section, Maven properties are also passed as attribute (replacing . by - in the name).
These include those defined in the `<properties>` section of the project, parent projects and the user's `settings.xml`.
+
[source,xml]
----
Expand Down

0 comments on commit ad9c325

Please sign in to comment.