Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow size and position of cover image to be set #1134

Closed
mojavelinux opened this issue Jul 6, 2019 · 1 comment
Closed

Allow size and position of cover image to be set #1134

mojavelinux opened this issue Jul 6, 2019 · 1 comment
Assignees
@mojavelinux
Labels
enhancement
Milestone
v1.5.0.beta.1

Comments

@mojavelinux
Copy link
Member

Allow the size (width) and position of the cover image to be set using the image macro.

Example:

:front-cover-image: cover.jpg[pdfwidth=50%,position=top]

This should match the behavior of the background image.
@mojavelinux mojavelinux added this to the v1.5.0.beta.1 milestone Jul 6, 2019
@mojavelinux mojavelinux self-assigned this Jul 6, 2019
@mojavelinux
Copy link
Member Author

As part of this change, move the logic to compute the image options to a helper method so it can be reused for cover images, background images, and images in running content.

mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Jul 7, 2019
@mojavelinux
resolves asciidoctor#1134 allow size and position of cover image to b…
4fc8713 
…e set
mojavelinux added a commit to mojavelinux/asciidoctor-pdf that referenced this issue Jul 7, 2019
@mojavelinux
resolves asciidoctor#1134 allow size and position of cover image to b…
f13977b 
…e set
mojavelinux added a commit that referenced this issue Jul 7, 2019
@mojavelinux
Merge PR #1135
cdb2af2 
resolves #1134 allow size and position of cover image to be set
@mojavelinux mojavelinux mentioned this issue Sep 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mojavelinux mojavelinux

Labels
enhancement
Projects
None yet
Milestone
v1.5.0.beta.1
Development

No branches or pull requests
1 participant
@mojavelinux