-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support remote includes #731
Labels
Comments
Did you try with |
You need to enable this feature by setting {
"asciidoc.preview.asciidoctorAttributes": {
"allow-uri-read": "",
}
} Having said that, it does not seems to work inside VS code: |
apupier
added a commit
to apupier/asciidoctor-vscode
that referenced
this issue
Jun 29, 2023
from what i understood, placing the allow-uri-read in attributes should have done the thing but it is not working... to investigate resolves asciidoctor#731 Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier
added a commit
to apupier/asciidoctor-vscode
that referenced
this issue
Jun 30, 2023
resolves asciidoctor#731 Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier
added a commit
to apupier/asciidoctor-vscode
that referenced
this issue
Jun 30, 2023
part of asciidoctor#731 Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier
added a commit
to apupier/asciidoctor-vscode
that referenced
this issue
Jun 30, 2023
part of asciidoctor#731 Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier
added a commit
to apupier/asciidoctor-vscode
that referenced
this issue
Jul 4, 2023
part of asciidoctor#731 Signed-off-by: Aurélien Pupier <apupier@redhat.com>
ggrossetie
pushed a commit
that referenced
this issue
Jul 4, 2023
part of #731 Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier
added a commit
to apupier/unxhr
that referenced
this issue
Aug 8, 2023
it avoids to rely on `process.execPath` which resolves to `code` binary in VS Code context although it expects the `node` binary relates to asciidoctor/asciidoctor-vscode#731 Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier
added a commit
to apupier/unxhr
that referenced
this issue
Aug 17, 2023
especially targeting VS Code fixes ggrossetie#98 relates to asciidoctor/asciidoctor-vscode#731 Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier
added a commit
to apupier/unxhr
that referenced
this issue
Aug 17, 2023
especially targeting VS Code fixes ggrossetie#98 relates to asciidoctor/asciidoctor-vscode#731 Signed-off-by: Aurélien Pupier <apupier@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently remote includes are not resolved (neither in the preview, neither in completion of attributes)
https://docs.asciidoctor.org/asciidoc/latest/directives/include-uri/#reference-include-content-by-uri
example:
preview gives:
![image](https://private-user-images.githubusercontent.com/1105127/247073818-e33c6051-c0f7-4aa6-a7f0-d7c24bb79ee0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUwNDQyMDIsIm5iZiI6MTcyNTA0MzkwMiwicGF0aCI6Ii8xMTA1MTI3LzI0NzA3MzgxOC1lMzNjNjA1MS1jMGY3LTRhYTYtYTdmMC1kN2MyNGJiNzllZTAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgzMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MzBUMTg1MTQyWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ODczMmRlZDQ1YWE0OTM2MjNjOWMxNGJhY2QzNGQzM2RmZTYzM2ZiZmZlZWNhZTNmMmZkMWMyMjE5ODgyY2MxZSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.NcHmrXSFRPrri5idRiPwUZzIcw5ULMC8Sp4LvLF6i-k)
The text was updated successfully, but these errors were encountered: