Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contributing guide #554

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Update contributing guide #554

merged 1 commit into from
Mar 16, 2022

Conversation

ggrossetie
Copy link
Member

What I Did

  • Remove the preamble since the commands are working on Linux, Windows and macOS (except npm run build-web && npx @vscode/test-web --browserType=chromium --extensionDevelopmentPath=${PWD} because of &&)
  • Mention the tests suite and how to run/debug it
  • Use inline code instead of source blocks

danyill
danyill approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@danyill danyill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I will hopefully look at others today.

@ggrossetie ggrossetie merged commit 40da7aa into master Mar 16, 2022
@ggrossetie ggrossetie deleted the update-contributing branch March 16, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyill danyill danyill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggrossetie @danyill