-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add doc role when the asciidoc page is used in an antora context #845
Conversation
Would you be able to add a test case in https://github.com/asciidoctor/asciidoctor-vscode/blob/master/src/test/asciidoctorWebViewConverter.test.ts to test with and without an |
Sure I will try to do that |
Co-authored-by: Guillaume Grossetie <ggrossetie@yuzutech.fr>
I added testcases but I cannot test them locally so please run the test and tell me if there needs to be changed something. I am getting the following error when I run the tests (independent from my change): I am currently woring on a WSL2 - Ubuntu Image with VSCode Remote Development. Maybe that is related. |
Ok, I am now able to run the Tests using the debugger. Now I have to figure out to test the content div. I will take a look later. |
The reason is that we are using You should create a new test case to convert a standalone document: https://docs.asciidoctor.org/asciidoctor/latest/api/convert-strings/#standalone-output const html = processor.convert(input, { converter: asciidoctorWebViewConverter, standalone: true }) |
fixed tests |
@ggrossetie Is anything missing from my side to merge this? |
No all good 👍🏻 |
…iidoctor#845) Co-authored-by: Guillaume Grossetie <ggrossetie@yuzutech.fr> Co-authored-by: Lasse Knudsen <lasse.knudsen@siemens.com>
Resolves #844