add getSourceLines and getSource to Block API #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I decided to use the API getSourceLines() instead of getLines() since it's a more accurate name. I may add that alias to core as well. |
|
It's also consistent with the method name on Document. |
ggrossetie
reviewed
Dec 25, 2017
spec/node/asciidoctor.spec.js
Outdated
| @@ -141,6 +141,8 @@ describe('Node.js', function () { | |||
| expect(blocks[1].getBlocks()[1].getId()).toBe('blockid'); | |||
| expect(blocks[1].getBlocks()[1].getStyle()).toBe('quote'); | |||
| expect(blocks[1].getBlocks()[1].getAttribute('attribution')).toBe('Abraham Lincoln'); | |||
| expect(blocks[1].getBlocks()[1].getSourceLines()).toEqual(['This is a quote.', 'It has a title, id, and attribution.']) | |||
There was a problem hiding this comment.
At some point we may switch to https://standardjs.com/ and remove semicolons but in the meantime... 😉
ggrossetie
requested changes
Dec 25, 2017
spec/node/asciidoctor.spec.js
Outdated
| @@ -141,6 +141,8 @@ describe('Node.js', function () { | |||
| expect(blocks[1].getBlocks()[1].getId()).toBe('blockid'); | |||
| expect(blocks[1].getBlocks()[1].getStyle()).toBe('quote'); | |||
| expect(blocks[1].getBlocks()[1].getAttribute('attribution')).toBe('Abraham Lincoln'); | |||
| expect(blocks[1].getBlocks()[1].getSourceLines()).toEqual(['This is a quote.', 'It has a title, id, and attribution.']) | |||
| expect(blocks[1].getBlocks()[1].getSource()).toBe('This is a quote.\nIt has a title, id, and attribution.') | |||
spec/node/asciidoctor.spec.js
Outdated
| @@ -141,6 +141,8 @@ describe('Node.js', function () { | |||
| expect(blocks[1].getBlocks()[1].getId()).toBe('blockid'); | |||
| expect(blocks[1].getBlocks()[1].getStyle()).toBe('quote'); | |||
| expect(blocks[1].getBlocks()[1].getAttribute('attribution')).toBe('Abraham Lincoln'); | |||
| expect(blocks[1].getBlocks()[1].getSourceLines()).toEqual(['This is a quote.', 'It has a title, id, and attribution.']) | |||
|
Perhaps you could add the linter as part of the test task. I always forgot to run it because it's not linked. |
mojavelinux
force-pushed
the
block-source-api
branch
from
e9373e2
to
97fa98a
Compare
Yes that's an excellent idea. It happened to me too! |
ggrossetie
approved these changes
Dec 26, 2017
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.