resolves #3992 use .bp macro at location of page break in manpage out…

…put (PR #3993)

CHANGELOG.adoc

@@ -22,6 +22,7 @@ Bug Fixes::
   * Remove extra .sp before content of verse block in manpage output
   * Fix layout of footnotes in manpage output (#3989)
   * Fix formatting of footnote text with URL in manpage output (#3988)
+  * Use .bp macro at location of page break in manpage output (#3992)
 
 Improvements::
 

lib/asciidoctor/converter/manpage.rb

@@ -314,8 +314,9 @@ def convert_open node
     end
   end
 
-  # TODO use Page Control https://www.gnu.org/software/groff/manual/html_node/Page-Control.html#Page-Control
-  alias convert_page_break skip
+  def convert_page_break node
+    '.bp'
+  end
 
   def convert_paragraph node
     if node.title?

test/manpage_test.rb

@@ -824,6 +824,32 @@
     end
   end
 
+  context 'Page breaks' do
+    test 'should insert page break at location of page break macro' do
+      input = <<~EOS.chop
+      #{SAMPLE_MANPAGE_HEADER}
+
+      == Section With Break
+
+      before break
+
+      <<<
+
+      after break
+      EOS
+      expected_coda = <<~'EOS'.chop
+      .SH "SECTION WITH BREAK"
+      .sp
+      before break
+      .bp
+      .sp
+      after break
+      EOS
+      output = Asciidoctor.convert input, backend: :manpage
+      assert output.end_with? expected_coda
+    end
+  end
+
   context 'Footnotes' do
     test 'should generate list of footnotes using numbered list with numbers enclosed in brackets' do
       [true, false].each do |standalone|