Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated methods from Document interface #1202

Closed
abelsromero opened this issue May 20, 2023 · 0 comments · Fixed by #1211
Closed

Remove deprecated methods from Document interface #1202

abelsromero opened this issue May 20, 2023 · 0 comments · Fixed by #1211
Labels
documentation enhancement
Milestone
3.0.0

Comments

@abelsromero
Copy link
Member

abelsromero commented May 20, 2023 •
edited

Methods already marked should be removed for v3.0.0 release.
Those are old methods that were created in alignment to Asciidoctor (hence Ruby) naming conventions instead of Java's. Newer versions have been available for a while with no feature differences.

One example is String doctitle(), this was deprecated in favor of String getDoctitle().

We'll need to document these changes in the migration guide.
@abelsromero abelsromero added this to the 3.0.0 milestone May 20, 2023
This was referenced May 20, 2023
Closed
Closed
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue May 22, 2023
@abelsromero
Remove deprecated methods from Document interface
e30b9f4 
* Improved 'org.asciidoctor.ast.Document' Javadocs

Fixes asciidoctor#1202
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue May 22, 2023
@abelsromero
v3 migration guide for 'Document' removed methods
00b7f12 
Fixes asciidoctor#1202
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue May 29, 2023
@abelsromero
Remove deprecated methods from Document interface
151a582 
* Improved 'org.asciidoctor.ast.Document' Javadocs

Fixes asciidoctor#1202
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue May 29, 2023
@abelsromero
v3 migration guide for 'Document' removed methods
8ce4726 
Fixes asciidoctor#1202
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue May 30, 2023
@abelsromero
Remove deprecated methods from Document interface
2e01e6b 
* Improved 'org.asciidoctor.ast.Document' Javadocs

Fixes asciidoctor#1202
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue May 30, 2023
@abelsromero
v3 migration guide for 'Document' removed methods
f330e68 
Fixes asciidoctor#1202
@abelsromero abelsromero mentioned this issue May 30, 2023
Merged
5 tasks
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue May 30, 2023
@abelsromero
v3 migration guide for 'Document' removed methods
7df16e8 
Fixes asciidoctor#1202
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue May 31, 2023
@abelsromero
Remove deprecated methods from Document interface
9862363 
* Improved 'org.asciidoctor.ast.Document' Javadocs

Fixes asciidoctor#1202
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue May 31, 2023
@abelsromero
v3 migration guide for 'Document' removed methods
751a6eb 
Fixes asciidoctor#1202
abelsromero added a commit to abelsromero/asciidoctorj that referenced this issue May 31, 2023
@abelsromero
v3 migration guide for 'Document' removed methods
1d78b5e 
Fixes asciidoctor#1202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Remove deprecated from Document interface abelsromero/asciidoctorj
1 participant
@abelsromero