Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated from Document interface #1211

Conversation

abelsromero
Copy link
Member

Kind of change

  • Bug fix
  • New non-breaking feature
  • New breaking feature
  • Documentation update
  • Build improvement

Description

What is the goal of this pull request?

Remove deprecated methods from Document interface
Improved 'org.asciidoctor.ast.Document' Javadocs

How does it achieve that?

Simply remove the marked methods and update tests and code accordingly.

Are there any alternative ways to implement this?

No

Are there any implications of this pull request? Anything a user must know?

Users will need to update their code if they use some of the removed methods.
The PR includes a migration guide.

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #1202

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

@abelsromero abelsromero force-pushed the issue-1202-remove-deprecated-from-Document-interface branch from f330e68 to 7df16e8 Compare May 30, 2023 17:58
@robertpanzer
Copy link
Member

Oops, looks like there is a merge conflict now. Sorry!

* Improved 'org.asciidoctor.ast.Document' Javadocs

Fixes asciidoctor#1202
@abelsromero
Copy link
Member Author

Oops, looks like there is a merge conflict now. Sorry!

No problem. Having the guides in partials makes it easy to handle. I'll move your parts to the top and keep that should not interfere with the other branches.

@abelsromero abelsromero force-pushed the issue-1202-remove-deprecated-from-Document-interface branch 2 times, most recently from 751a6eb to 1d78b5e Compare May 31, 2023 17:16
@abelsromero
Copy link
Member Author

Also extracted the text about "removal of asMap" into it's own partial.

@robertpanzer
Copy link
Member

Awesome, thank you!

@robertpanzer robertpanzer merged commit 9087ec0 into asciidoctor:main Jun 1, 2023
11 checks passed
@abelsromero abelsromero deleted the issue-1202-remove-deprecated-from-Document-interface branch November 26, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated methods from Document interface
2 participants