Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use diamond, remove unnecessary public keyword on interfaces #720

Merged
merged 1 commit into from
Nov 8, 2018
Merged

Use diamond, remove unnecessary public keyword on interfaces #720

merged 1 commit into from
Nov 8, 2018

Conversation

ggrossetie
Copy link
Member

A little code cleanup in the extension package (to reduce the code changes in #715).

If you want to do a single commit to use diamond operator everywhere I can do it. I can also remove the unnecessary public keyword from interfaces at once ?

@robertpanzer robertpanzer merged commit 2da6dd3 into asciidoctor:master Nov 8, 2018
@robertpanzer
Copy link
Member

Thanks!
We can also iterate and update the code in steps.
At the time I added the public modifier to the interface methods because there's also the private modifier now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants