This repository has been archived by the owner on Dec 28, 2022. It is now read-only.
Windows stdout hook #175
Merged
Windows stdout hook #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
force-pushed
the
feature/windows-stdout-hook
branch
from
108744d
to
4433287
Compare
|
@escay now you have the same behavior on Windows than the Linux platforms 😉 |
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On Windows, AsciiDoctor.js try to write on
process.stdoutandprocess.stderrwhen a document have syntax error but this crash the preview.Now the errors are properly displayed in the console and the document is rendered.
I removed the specific message in the error page.
Fix #172 and #159.
Related to electron/electron#2033