Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asciidoctor-diagram doesn't work on alpine based image #44

Closed
ryosms opened this issue Oct 13, 2017 · 6 comments
Closed

asciidoctor-diagram doesn't work on alpine based image #44

ryosms opened this issue Oct 13, 2017 · 6 comments
Assignees

Comments

@ryosms
Copy link

ryosms commented Oct 13, 2017

with this sample.adoc file:

= sample

[plantuml,sample-diagram,svg]
----
class Sample {
}
----

I try below, and I've got error

$ docker run -it --rm -v $(pwd)/documents:/documents asciidoctor/docker-asciidoctor
bash-4.3# asciidoctor -r asciidoctor-diagram sample.adoc

asciidoctor-diagram: ERROR: Failed to generate image: Could not find Java executable
@mojavelinux
Copy link
Member

mojavelinux commented Oct 13, 2017

I think there was a misunderstanding the the JDK was only needed for fopub, which was removed from the image. (See #39 (comment)). However, the JDK is definitely needed for asciidoctor-diagram as several of the diagramming tools use it (namely plantuml).

@wimdeblauwe
Copy link

I would love to see this fixed as well. The main reason for running the document creation in docker is to avoid people having to install all kind of things to make the diagrams work.

@dduportal
Copy link
Contributor

Hello!

Thank you for writing this issue!

As @mojavelinux stated, it was a misunderstanding from me. I apologize for the inconvenience.

Expect a fix to be proposed this weekend, with this issue's reproduction case as test for non-reproduction in the future.

@dduportal
Copy link
Contributor

Hello @ryosms,

The "latest" Docker Image has been rebuilt with the support (back) of asciidoctor-diagram.

You can get it v-by re-pulling the image with the following command:

docker pull asciidoctor/docker-asciidoctor

Feel free to re-open this issue if you face any issue or if you are not happy with the result.

Thanks for taking time for reporting!

@aowss
Copy link

aowss commented Feb 25, 2022

i think that problem has been re-introduced in 1.17

@dduportal
Copy link
Contributor

i think that problem has been re-introduced in 1.17

Hello @aowss ! Thanks for reporting!
Could you share a reproduction case please and reopen the issue please?

Since 1.17 has an updated JDK to a major version, it might have broke something. Alas the test harnes did not show anything: either we are missing a mandatory test case, or the existing test cases aren't good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants