-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
asciidoctor-diagram doesn't work on alpine based image #44
Comments
I think there was a misunderstanding the the JDK was only needed for fopub, which was removed from the image. (See #39 (comment)). However, the JDK is definitely needed for asciidoctor-diagram as several of the diagramming tools use it (namely plantuml). |
I would love to see this fixed as well. The main reason for running the document creation in docker is to avoid people having to install all kind of things to make the diagrams work. |
Hello! Thank you for writing this issue! As @mojavelinux stated, it was a misunderstanding from me. I apologize for the inconvenience. Expect a fix to be proposed this weekend, with this issue's reproduction case as test for non-reproduction in the future. |
Hello @ryosms, The "latest" Docker Image has been rebuilt with the support (back) of asciidoctor-diagram. You can get it v-by re-pulling the image with the following command: docker pull asciidoctor/docker-asciidoctor Feel free to re-open this issue if you face any issue or if you are not happy with the result. Thanks for taking time for reporting! |
i think that problem has been re-introduced in 1.17 |
Hello @aowss ! Thanks for reporting! Since 1.17 has an updated JDK to a major version, it might have broke something. Alas the test harnes did not show anything: either we are missing a mandatory test case, or the existing test cases aren't good enough. |
with this sample.adoc file:
I try below, and I've got error
$ docker run -it --rm -v $(pwd)/documents:/documents asciidoctor/docker-asciidoctor bash-4.3# asciidoctor -r asciidoctor-diagram sample.adoc asciidoctor-diagram: ERROR: Failed to generate image: Could not find Java executable
The text was updated successfully, but these errors were encountered: