-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #44: Re-Enabling Asciidoctor-diagram usage #46
Conversation
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
We probably want a slightly more complex example to make sure we put some weight on graphviz to verify it works. Perhaps @pepijnve can advise. @pepijnve do you have a go-to example that you use (perhaps from the test suite) that thoroughly tests the graphviz setup? I'm pretty sure all we need is a JRE. |
… clean file avoiding errors. Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
The build on my own TravisCI was broken due to the "files owned by root" when cleaning the test cases: https://travis-ci.org/dduportal/docker-asciidoctor/builds/288124855 Just added a fix on the test harness suite to avoid breaking any kind of CI, by using "docker for everything" pattern. |
Hello @mojavelinux! I just want to be sure I get the goal: Should we:
|
I'm fine with moving forward and filing a separate issue for strong tests. I just mentioned it because I'm concerned this is going to keep biting us if we don't test it more thoroughly. |
This Pull Request have been merged. @mojavelinux, the issue #48 has been opened to keep track of the graphviz test weight. |
Thanks @dduportal! |
The Pull Request #39 broke the usage of Asciidoctor-diagram.
This pull request aims to fix it, by introducing the following:
[EDIT]
The image is built (and updated) on the DockerHub and can be pulled without building it: