-
-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manifest.jsonの作成 #460
Manifest.jsonの作成 #460
Conversation
Deploy preview for js-primer ready! Built with commit 93c95b0 |
source/_layouts/website/page.html
Outdated
@@ -31,4 +31,5 @@ | |||
margin-bottom: 1.275em | |||
} | |||
</style> | |||
<link rel="manifest" href="./manifest.json"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
こちらも同じように /manifest.json
じゃないとページによってはアクセスできない気がします。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
修正しました!
"name": "JavaScriptの入門書", | ||
"start_url": "https://asciidwango.github.io/js-primer/", | ||
"icons": [ | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
アイコンまだ特にないんですよね。
てきとうに文字だけのアイコンを作って置くとかがいいのかなー。
(add to homescreenすると多分リクエストが飛んで404になるので)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
了解です 🙆♂️
6da070d
to
c31adda
Compare
なるほど... 個人的には, 特にこだわり等なければ,
でとりあえずwork around的に解決でいいと思います |
|
source/_layouts/website/page.html
Outdated
@@ -31,5 +31,6 @@ | |||
margin-bottom: 1.275em | |||
} | |||
</style> | |||
<link rel="manifest" href="/manifest.json"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
などで /
が指す場所がことなるため
"{{ "/"|resolveFile }}/manifest.json"
のように書いて相対パスに変換しないとダメでした。 🙇
<link rel="manifest" href="{{ "/"|resolveFile }}/manifest.json">
参考
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
確かに、そこの対応は必要そうですね...
今、 https://asciidwango.github.io/js-primer/ の方で確認してみたら、
この記述でも以下のエラーが出ています...
僕の方でも少し確認してみます 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<script type="text/javascript" src="{{ "/"|resolveFile }}/sw-register.js"></script>
が
https://asciidwango.github.io/js-primer/.sw-register.js
になってしまうのか。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<script type="text/javascript" src="{{ "/sw-register.js"|resolveFile }}"></script>
が正解な気がしてきました。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<link rel="manifest" href="{{ "/manifest.json"|resolveFile }}">
が正解だったようです。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
了解しました 👍
ありがとうございます 🙇 |
Related #431
Manifest.jsonを作成しました
未着手
Iconは、どうすれば良いかわからなかったので、教えていただけると助かります 🙇
(とりあえず, 仮のものをおいておきました)