feature: result formatter extensibility with minor refactor and sever… #58
Conversation
|
@dsalahutdinov great pull request, thanks. #57 consolidates lots of things in the code, so it would be good to merge that before this PR, if you agree. |
|
@asciimoo , that's ok, i will renew my PR after merging of those |
|
@dsalahutdinov thanks. |
dsalahutdinov
force-pushed
the
master
branch
2 times, most recently
from
e8a590c
to
ecb483a
Compare
|
@asciimoo i've done |
.travis.yml
Outdated
| @@ -9,9 +9,7 @@ os: | |||
| env: | |||
| - "PATH=/home/travis/gopath/bin:$PATH" | |||
| script: | |||
| - test -z "$(gofmt -l ./)" | |||
| - test -z "$(go vet -v ./...)" | |||
| - go build | |||
There was a problem hiding this comment.
I think, these checks would be still useful. Does go test evaluate these too?
There was a problem hiding this comment.
Yeah, unless go test already does it, the gofmt check should definitely remain there. It's already caught a couple misformatted PRs.
|
+1, except for travis mods. @dsalahutdinov could you please add |
|
Yes. I'll do it soon. Having some holidays now |
dsalahutdinov
force-pushed
the
master
branch
from
ecb483a
to
a444ba3
Compare
|
@asciimoo , i've done |
wuzz.go
Outdated
| } | ||
| } | ||
| responseFormatter := formatter.New(a.config, req.ContentType) | ||
| vrb.Title = "Response body (F9) " + responseFormatter.Title() |
There was a problem hiding this comment.
Could you use https://github.com/asciimoo/wuzz/blob/master/wuzz.go#L191 instead of hard-coding the title prefix?
There was a problem hiding this comment.
done, sorry for my inattention 😞
dsalahutdinov
force-pushed
the
master
branch
from
a444ba3
to
bf8090f
Compare
dsalahutdinov
force-pushed
the
master
branch
from
bf8090f
to
e6e3643
Compare
|
Thank you |
…al testsy
Hi. Some refactor to make adding new result view format depend of content-type easy