Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for asciicast:play window message removed #250

Closed
fghaas opened this issue Apr 19, 2017 · 4 comments
Closed

Support for asciicast:play window message removed #250

fghaas opened this issue Apr 19, 2017 · 4 comments

Comments

@fghaas
Copy link

fghaas commented Apr 19, 2017

I used the asciicast:play window event with much success from reveal.js a couple of years ago (see #175). I am trying to figure out where it went, because it no longer seems to be available the way it was.

  • app/views/layouts/raw.html.slim (which contained the necessary functionality at the time) was renamed to app/views/layouts/bare.html.slim in edca762.
  • Then, bare.html.slim became show.html.slim in 06c19ad.
  • In baf1c96, it was decided that there is "no need for jQuery inside of an iframe", and in the process the $('.start-prompt').click(); was replaced with a TODO.
  • Then, that TODO was dropped a couple of months ago as "dead code", in 5992e9b.

Now, there's no trace of the asciicast:play event left in the code, so what can I do to bring that functionality back?

@ku1ik
Copy link
Contributor

ku1ik commented Apr 20, 2017

Hej Florian! It seems we lost it indeed. Like you found out, there was a chain of loosely related changes. And to be honest, I thought "nobody uses this anyway", as this functionality wasn't officially documented. My bad 😬

Let me take a look at this!

@fghaas
Copy link
Author

fghaas commented Apr 20, 2017

Thanks for looking into this. To be fair, I never managed to get the functionality into reveal.js proper (see discussion in hakimel/reveal.js#1382).

By the way, since you're already considering bringing it back. To just cover the reveal.js use case, it posts a generic slide:start message to all embedded iframes, so if you want to add that in addition to bringing back the old asciicast:play event, then reveal could even auto-start playback without modifications at all (see here).

@fghaas fghaas changed the title Where did support for the asciicast:play window event go? Support for asciicast:play window message removed Apr 20, 2017
@ku1ik
Copy link
Contributor

ku1ik commented Apr 20, 2017

Thanks for bringing up reveal.js sent events, this is cool.

Anyway, I've brought back the original event handling + added reveal.js support in #251.

@ku1ik
Copy link
Contributor

ku1ik commented Jun 4, 2017

Fixed in #251

@ku1ik ku1ik closed this as completed Jun 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants