-
-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for asciicast:play window message removed #250
Comments
Hej Florian! It seems we lost it indeed. Like you found out, there was a chain of loosely related changes. And to be honest, I thought "nobody uses this anyway", as this functionality wasn't officially documented. My bad 😬 Let me take a look at this! |
Thanks for looking into this. To be fair, I never managed to get the functionality into reveal.js proper (see discussion in hakimel/reveal.js#1382). By the way, since you're already considering bringing it back. To just cover the reveal.js use case, it posts a generic |
Thanks for bringing up reveal.js sent events, this is cool. Anyway, I've brought back the original event handling + added reveal.js support in #251. |
Fixed in #251 |
I used the
asciicast:play
window event with much success from reveal.js a couple of years ago (see #175). I am trying to figure out where it went, because it no longer seems to be available the way it was.app/views/layouts/raw.html.slim
(which contained the necessary functionality at the time) was renamed toapp/views/layouts/bare.html.slim
in edca762.bare.html.slim
becameshow.html.slim
in 06c19ad.$('.start-prompt').click();
was replaced with a TODO.Now, there's no trace of the
asciicast:play
event left in the code, so what can I do to bring that functionality back?The text was updated successfully, but these errors were encountered: