Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autoplay support for asciinema #1382

Closed
wants to merge 1 commit into from
Closed

Add autoplay support for asciinema #1382

wants to merge 1 commit into from

Conversation

fghaas
Copy link
Contributor

@fghaas fghaas commented Oct 3, 2015

Asciinema is a popular service allowing users to record terminal screencasts ("asciicasts") and play them back in a react.js based player, enabling easy after-the-fact manipulation of color themes, font size, playback speed etc.

Since asciinema/asciinema-server@2913c045, Asciinema supports an asciicast:play event that enables autoplay. Fix up reveal.js in the same way as previously for Vimeo and YouTube.

This patch should also apply cleanly to master.

For background, see also asciinema/asciinema-server#175.

Asciinema (https://asciinema.org/) is a popular service allowing users
to record terminal screencasts ("asciicasts") and play them back in
a react.js based player, enabling easy after-the-fact manipulation of
color themes, font size, playback speed etc.

Since asciinema/asciinema-server@2913c045, Asciinema supports an
"asciicast:play" event that enables autoplay. Fix up reveal.js in the
same way as previously for Vimeo and YouTube.
@Delapouite
Copy link

Hi

Youtube and vimeo support also appears in the stopEmbeddedContent function just below your contribution,
Do you think asciinema should be added there as well?

@fghaas
Copy link
Contributor Author

fghaas commented Nov 10, 2015

@Delapouite I'm afraid that wouldn't make sense. Asciinema has an API method that allows playing an asciicast, but not one that allows stopping or pausing it. See https://github.com/asciinema/asciinema.org/blob/master/app/views/api/asciicasts/show.html.slim if you want to take a look.

@bnjmnt4n
Copy link
Collaborator

This seems quite specific, and is better suited to a plugin IMO. YouTube and Vimeo are used by a large number of people, while I think much less people use Asciicinema. Perhaps this is better suited to a plugin.

@fghaas
Copy link
Contributor Author

fghaas commented Mar 22, 2016

A completely unintrusive three-line patch, and you want a plugin for that? Are you sure?

@bnjmnt4n
Copy link
Collaborator

IMO functionality which isn't used widely shouldn't have a need to be in the core scripts. Although this might be a 3 line patch, if everyone were to submit small patches like this for every single service, the file would become extremely bloated. In the end though, it's up to @hakimel to make the decison.

@fghaas
Copy link
Contributor Author

fghaas commented Mar 22, 2016

Look, I don't mind, I've had this in my own fork for a while anyway and don't mind keeping it that way. Also, seeing as this patch has been sitting here for 5 months I hadn't expected it to go in. Let's close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants