Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asciinema 1.3 does not provide a wrapper #174

Closed
carnager opened this issue Aug 1, 2016 · 5 comments
Closed

asciinema 1.3 does not provide a wrapper #174

carnager opened this issue Aug 1, 2016 · 5 comments

Comments

@carnager
Copy link

carnager commented Aug 1, 2016

Since asciinema is now installed in python's site-packages directory, the binary won't be in $PATH anymore.

asciinema should probably provide a little wrapper to be placed in $PATH. I guess setup.py is the place to do this.
@ku1ik ku1ik mentioned this issue Aug 2, 2016
Closed
@ku1ik
Copy link
Contributor

ku1ik commented Aug 3, 2016

setup.py has it configured: https://github.com/asciinema/asciinema/blob/master/setup.py#L29
In all systems I checked asciinema installation it was correctly creating a wrapper script.

@fornwall
Copy link
Contributor

When I installed from source with python3.5 setup.py install, the resulting installation did not have the asciinema command-line wrapper.

I noticed the warnings

/usr/lib/python3.5/distutils/dist.py:261: UserWarning: Unknown distribution option: 'entry_points'
/usr/lib/python3.5/distutils/dist.py:261: UserWarning: Unknown distribution option: 'install_requires'

I had to pip3 install setuptools - after that the installation correctly set up the bin/asciinema wrapper.

I don't know enough about python packaging to know if this is the expected behaviour or not.

@ku1ik
Copy link
Contributor

ku1ik commented Aug 31, 2016

Does anyone know a way to make it generate a wrapper in a reliable way (also in the absence of setuptools)?

jakubjedelsky pushed a commit to jakubjedelsky/asciinema-cli that referenced this issue Oct 12, 2016
setup: distutils can't create wrapper in $PATH
eb7e728 
Module `distutils` don't know options `install_requires` and
`entry_points`. The second one is important for creating `asciinema`
binary within $PATH.

This should "resolve" Issue asciinema#174.
@jakubjedelsky jakubjedelsky mentioned this issue Oct 12, 2016
Merged
jakubjedelsky added a commit to jakubjedelsky/asciinema-cli that referenced this issue Oct 13, 2016
@jakubjedelsky
setup: distutils can't create wrapper in $PATH
30e5290 
Module `distutils` don't know options `install_requires` and
`entry_points`. The second one is important for creating `asciinema`
binary within $PATH.

This should "resolve" Issue asciinema#174.
@ku1ik
Copy link
Contributor

ku1ik commented Mar 9, 2017

This has been solved in #179, the fix will be part of the next release.

@ku1ik
Copy link
Contributor

ku1ik commented Apr 11, 2017

1.4.0 has been just released, including fix (#179) by @jakubjedelsky.

@ku1ik ku1ik closed this as completed Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ku1ik @fornwall @carnager