Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit upload .cast file url #357

Closed
wants to merge 1 commit into from
Closed

Conversation

v1xingyue
Copy link

Some http servers such as nginx, will return a 301 redirect , when you post to a url not ended with / .

When Post To /asciinema/api/asciicasts ,
It will return :
301 /asciinema/api/asciicasts/ ,

Some http servers such as nginx, will return a 301 redirect , when you post to a url not ended with / . 

When Post To  /asciinema/api/asciicasts , 
It will return  : 
301 /asciinema/api/asciicasts/ ,
@ku1ik
Copy link
Contributor

ku1ik commented Sep 8, 2019

Thanks, however, for the ones which don't redirect and don't handle path with and without trailing slash the same it could also break upload. asciinema-server handles the one without slash just fine. What kind of setup you have where this doesn't work today? I don't think Nginx will do the redirect when using upstream directive unless it's explicitly told so.

@v1xingyue v1xingyue closed this Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants