Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json and .gitignore #11

Merged
merged 2 commits into from
May 20, 2017
Merged

package.json and .gitignore #11

merged 2 commits into from
May 20, 2017

Conversation

asconwe
Copy link
Owner

@asconwe asconwe commented May 18, 2017

Checkittttt

Copy link
Collaborator

@John-Hong John-Hong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eww

Copy link
Collaborator

@narst20 narst20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have heroku information?

@asconwe
Copy link
Owner Author

asconwe commented May 18, 2017

Heroku would go somewhere else...

@asconwe
Copy link
Owner Author

asconwe commented May 18, 2017

@John-Hong no way

@@ -4,8 +4,8 @@ var methodOverride = require('method-override');
var bodyParser = require('body-parser');
var exphbs = require("express-handlebars");
//==============Local dependencies
var db = require("./models");
var controller = require('./controllers/controller') // Name controllers accordingly
// var db = require("./models");
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out references to db until we have sequelize stuff from @narst20

@asconwe
Copy link
Owner Author

asconwe commented May 19, 2017

@John-Hong @narst20 FYI - the controller.js file behaves like the Sequelize index.js file, so it requires all the js files in the controllers directory. So, in our server.js file, we just need to require controller.js and call it with controller(app), like on line 30 in server.js

Also - someone review my code, pleaaaase

@narst20 narst20 merged commit 3886f3c into master May 20, 2017
This was referenced May 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants