Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memoryfilesystem #450

Merged
merged 6 commits into from
May 7, 2023
Merged

Conversation

marschall
Copy link
Contributor

This PR does some of the work to switch from Jimfs to memoryfilesystem.

This has failing tests:

  • JimfsFileSystemProviderImplTest.theCreatedFileSystemSupportsDirectoryStreams:166 » IllegalState #iterator() already called. DirectoryStream#iterator() is specified to throw IllegalStateException if the iterator has already been returned
  • JarFactoryImplTest.exceptionRaisedIfOutputJarDirectoryDoesNotExist:76
Expecting message to be:
  "/some-non-existent-directory/HelloWorld.jar"
but was:
  "/some-non-existent-directory"

assertions on exception messages are quite brittle. It would probably be safer to use java.nio.file.FileSystemException#getFile()

  • FileUtilsTest.retrieveRequiredUrlCanDereferencePathsToUrls:89
Expecting actual:
  "memory:45377dad-eb8b-42ac-96df-5d3d9f18e5c9:///foo/bar/baz.txt"
to start with:
  "memory://"

The JimfsFileSystemProviderImpl* classes should probably be renamed.

I do not plan to put any more work into this PR.

@ascopes
Copy link
Owner

ascopes commented May 7, 2023

Thanks for taking a look on your side and putting the work into putting this up, it is greatly appreciated! Will merge this into a feature branch on my side to have a play with getting some of those tests running.

Looks all good to me though!

@ascopes ascopes changed the base branch from main to feature/GH-311 May 7, 2023 13:18
@ascopes ascopes merged commit 8173bf8 into ascopes:feature/GH-311 May 7, 2023
@ascopes ascopes self-assigned this May 7, 2023
@ascopes ascopes added the new feature A new feature label May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants