Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some of the work to switch from Jimfs to memoryfilesystem.
This has failing tests:
JimfsFileSystemProviderImplTest.theCreatedFileSystemSupportsDirectoryStreams:166 » IllegalState #iterator() already called
. DirectoryStream#iterator() is specified to throwIllegalStateException
if the iterator has already been returnedassertions on exception messages are quite brittle. It would probably be safer to use
java.nio.file.FileSystemException#getFile()
The
JimfsFileSystemProviderImpl*
classes should probably be renamed.I do not plan to put any more work into this PR.