Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.0 breaking changes #566

Merged
merged 2 commits into from
Oct 14, 2023
Merged

v2.0.0 breaking changes #566

merged 2 commits into from
Oct 14, 2023

Conversation

ascopes
Copy link
Owner

@ascopes ascopes commented Sep 26, 2023

Changes for the v2.0.0 release.

  • Remove deprecated JctFileManagers#newJctFileManager.

@ascopes ascopes added documentation Improvements or additions to documentation housekeeping new feature A new feature java Changes to Java code labels Sep 26, 2023
@ascopes ascopes self-assigned this Sep 26, 2023
@ascopes ascopes marked this pull request as draft September 26, 2023 07:11
@ascopes ascopes changed the title V2.0.0 changes v2.0.0 breaking changes Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #566 (9dfcb5d) into main (eb5a322) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #566      +/-   ##
==========================================
- Coverage   88.48%   88.48%   -0.01%     
==========================================
  Files          95       95              
  Lines        2953     2952       -1     
  Branches      237      237              
==========================================
- Hits         2613     2612       -1     
  Misses        292      292              
  Partials       48       48              
Files Coverage Δ
...thub/ascopes/jct/filemanagers/JctFileManagers.java 100.00% <ø> (ø)

@github-actions
Copy link

github-actions bot commented Sep 26, 2023

Test Results

  3 360 files    3 360 suites   5s ⏱️
32 302 tests 32 041 ✔️ 261 💤 0
32 627 runs  32 366 ✔️ 261 💤 0

Results for commit 9dfcb5d.

♻️ This comment has been updated with latest results.

Signed-off-by: ascopes <73482956+ascopes@users.noreply.github.com>
Remove deprecated-for-removal method.

Signed-off-by: ascopes <73482956+ascopes@users.noreply.github.com>
@ascopes ascopes marked this pull request as ready for review October 14, 2023 07:50
@ascopes ascopes merged commit a595acc into main Oct 14, 2023
22 checks passed
@ascopes ascopes deleted the feature/v2 branch October 14, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation java Changes to Java code new feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant