Fix bottom for source size == 1 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreidmt
approved these changes
Nov 18, 2021
andreidmt
pushed a commit
that referenced
this pull request
Nov 18, 2021
## [7.5.1](v7.5.0...v7.5.1) (2021-11-18) ### Bug Fixes * **bottom:** issue returning an empty array when source size is exactly 1 and limit is grater ([#13](#13)) ([466cae6](466cae6))
|
🎉 This PR is included in version 7.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thanks a lot for the speedy merge! Looking forward to that typing as well :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary
bottomwhen the source size is exactly 1 and the limit is longer than that - it was removing that element when it should not.Checklist
src/index.js