Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-all doesn't work if one plugin don't need update, add-all doesn't work if one plugin already installed #38

Closed
tblaisot opened this issue Nov 8, 2023 · 0 comments · Fixed by #45 or #47
Assignees
Labels
bug Something isn't working

Comments

@tblaisot
Copy link

tblaisot commented Nov 8, 2023

Describe the bug

When using asdf-plugin-manager update-all if one of the plugins doesn't need update, the script stop with return code 0 without testing other dependencies

Steps to reproduce

Using the following .plugin-versions file

alias                https://github.com/andrewthauer/asdf-alias.git             1209ad5
gcloud               https://github.com/jthegedus/asdf-gcloud.git                   14d1c0d
golang               https://github.com/kennyp/asdf-golang.git                  f006a12
helm                 https://github.com/Antiarchitect/asdf-helm.git             a39e17b

use asdf-plugin-manager update-all

The output is

[INFO] Updating: alias https://github.com/andrewthauer/asdf-alias.git 1209ad5 to HEAD
Updating alias to main
Already on 'main'
Your branch is up to date with 'origin/main'.
[INFO] The plugin "alias" with git-ref "1209ad5" is already up-to-date.

execute

asdf-plugin-manager add alias #add one of the plugin already
asdf-plugin-manager add-all

The output is

[INFO] Adding: alias https://github.com/andrewthauer/asdf-alias.git 1209ad5
Plugin named alias already added

Expected behavior

The update-all command should try to update all plugins.
The add-all command should try to install all the plugins even if one is already installed

Additional context

@tblaisot tblaisot added the bug Something isn't working label Nov 8, 2023
@aabouzaid aabouzaid self-assigned this Jan 23, 2024
dochang added a commit to dochang/asdf-plugin-manager that referenced this issue Mar 2, 2024
dochang added a commit to dochang/asdf-plugin-manager that referenced this issue Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
2 participants