Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate asdf_extensions entry point #1361

Conversation

braingram
Copy link
Contributor

@braingram braingram commented Feb 10, 2023

The asdf_extensions entry point is only used by the legacy, deprecated extension api.

This PR adds a deprecation warning triggered when this entry point is used.

Fixes #1333

@braingram braingram force-pushed the deprecate/asdf_extensions_entry_point branch from df276e6 to 1a7c47b Compare February 13, 2023 16:25
@WilliamJamieson WilliamJamieson added this to the 2.15 milestone Feb 15, 2023
@braingram braingram force-pushed the deprecate/asdf_extensions_entry_point branch 2 times, most recently from 1e9e2ad to d25bfde Compare February 22, 2023 19:07
@braingram
Copy link
Contributor Author

braingram commented Feb 22, 2023

This is based off changes in #1429 and should not be merged before that PR.

@braingram braingram force-pushed the deprecate/asdf_extensions_entry_point branch from d25bfde to 31a4d25 Compare February 22, 2023 19:52
@braingram braingram marked this pull request as ready for review February 22, 2023 19:53
@braingram braingram requested a review from a team as a code owner February 22, 2023 19:53
pyproject.toml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
asdf/tests/helpers.py Outdated Show resolved Hide resolved
@braingram braingram force-pushed the deprecate/asdf_extensions_entry_point branch from 31a4d25 to 4aded1b Compare February 22, 2023 22:00
@braingram
Copy link
Contributor Author

@WilliamJamieson Thanks for catching those. They were all stale changes that are no longer required due to the work done to revive this PR.

Copy link
Contributor

@WilliamJamieson WilliamJamieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please rebase to pickup up the .tox changes.

asdf/tests/test_entry_points.py Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@braingram braingram deleted the deprecate/asdf_extensions_entry_point branch February 24, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add deprecations for 'legacy' extension system
2 participants