Deprecate AsdfExtension, AsdfExtensionList, BuiltinExtension #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braingram
force-pushed
the
deprecate/asdf_extension
branch
from
0e38f0a
to
bb47d76
Compare
This was referenced Feb 22, 2023
|
|
braingram
force-pushed
the
deprecate/asdf_extension
branch
from
6ec8e60
to
96c6902
Compare
braingram
force-pushed
the
deprecate/asdf_extension
branch
from
96c6902
to
fc3b5a5
Compare
WilliamJamieson
approved these changes
Feb 22, 2023
Comment on lines
+35
to
+43
| def __getattr__(name): | ||
| if name == "AsdfExtension": | ||
| # defer import to only issue deprecation warning when | ||
| # asdf.AsdfExtension is used | ||
| from asdf import extension | ||
|
|
||
| return extension.AsdfExtension | ||
| msg = f"module {__name__!r} has no attribute {name!r}" | ||
| raise AttributeError(msg) |
|
How did this not show up in #1433? From the astropy downstream
|
|
astropy downstream will be fixed by astropy/astropy#14436 |
meeseeksmachine
pushed a commit
to meeseeksmachine/asdf
that referenced
this pull request
Feb 22, 2023
…ist, BuiltinExtension
This was referenced Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently based off of #1409 and should not be merged before that PR.