Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

np.product is deprecated in numpy 1.25 #1470

Merged
merged 2 commits into from
Mar 9, 2023
Merged

np.product is deprecated in numpy 1.25 #1470

merged 2 commits into from
Mar 9, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Mar 9, 2023

@pllim pllim requested a review from a team as a code owner March 9, 2023 19:50
@github-actions github-actions bot added this to the 2.15.0 milestone Mar 9, 2023
@braingram braingram mentioned this pull request Mar 9, 2023
Merged
@braingram
Copy link
Contributor

Thanks!

There appears to be one more usage of product here:

asdf/asdf/tags/core/ndarray.py

Line 332 in 40eb2ea

stride = strides[0] if strides is not None else np.product(shape[1:]) * dtype.itemsize

Would you mind adding that change to this PR?

@pllim
Copy link
Contributor Author

pllim commented Mar 9, 2023

Done.

braingram
braingram approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM when the CI passes.

@braingram braingram merged commit 71c4f0b into asdf-format:master Mar 9, 2023
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 9, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/asdf that referenced this pull request Mar 9, 2023
@braingram @meeseeksmachine
Backport PR asdf-format#1470: np.product is deprecated in numpy 1.25
16661d8
@pllim pllim deleted the patch-1 branch March 9, 2023 20:41
github-actions bot pushed a commit that referenced this pull request Mar 10, 2023
@braingram @github-actions
Backport PR #1470: np.product is deprecated in numpy 1.25
0f4860b
@braingram braingram mentioned this pull request Mar 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braingram braingram braingram approved these changes

Assignees
No one assigned
Labels
backport-2.15.x no-changelog-entry-needed
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pllim @braingram