Fix numpy 1.25 deprecation warnings.

[dstansby]

In numpy 1.25 several functions will be deprecated. I've either replaced the functions with like-for-like functions that aren't deprecated, or filtered the warnings in tests that should stay.

Fixes #14509.

[github-actions]

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

• Do the proposed changes actually accomplish desired goals?
• Do the proposed changes follow the Astropy coding guidelines?
• Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
• Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
• Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
• Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
• Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
• Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
• Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
• At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

[larrybradley]

convolution changes look fine.

[dstansby]

While I was at it I updated this to hopefully fix all the numpy 1.25 deprecation warnings

[pllim]

Also, I think you missed one -- https://github.com/astropy/astropy/actions/runs/4376653449/jobs/7659080296

[dstansby]

Also, I think you missed one -- https://github.com/astropy/astropy/actions/runs/4376653449/jobs/7659080296

It looks like that's coming from asdf, not astropy

[pllim]

In that case, please ignore that warning locally for this failure. Thanks!

        if Version(asdf.__version__) >= Version("2.8.0"):
            # The auto_inline argument is deprecated as of asdf 2.8.0.
            with asdf.config_context() as config:
                config.array_inline_threshold = 64
>               assert_roundtrip_tree({"table": t}, tmpdir, asdf_check_func=check)

astropy/io/misc/asdf/tags/table/tests/test_table.py:126: 

[mhvk]

This looks good! I put an inline note that we did it a bit differently in #14484, so maybe we should keep it the same. But really it doesn't matter; could even change the construct there to be the same as you have it here.

[pllim]

👍 to keep things consistent with #14484

[dstansby]

👍 I went with the option of filtering the warnings, as it leads to a much clearer test function body.

[mhvk]

Looks all good to me!

[pllim]

I don't like removing NUMPY_LT_1_25. Makes it hard to grep and remove dead code when we eventually bump minversion to numpy 1.25. Can we at least leave # NUMPY_LT_1_25 here for future grep?

[pllim]

Unless numpy dev remove it first before that happens but I can't tell the future.

[dstansby]

👍 done

[WilliamJamieson]

Modeling changes look fine to me

[mhvk]

@dstansby - thanks! let's get this in.

[lumberbot-app]

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

git checkout v5.0.x
git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

git cherry-pick -x -m1 64f58aeac6a8651a5e7c405bbbab837f73d89fb2

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

git commit -am 'Backport PR #14510: Fix numpy 1.25 deprecation warnings.'

4. Push to a named branch:

git push YOURFORK v5.0.x:auto-backport-of-pr-14510-on-v5.0.x

5. Create a PR against branch v5.0.x, I would have named this PR:

"Backport PR #14510 on branch v5.0.x (Fix numpy 1.25 deprecation warnings.)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

[lumberbot-app]

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

git checkout v5.2.x
git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

git cherry-pick -x -m1 64f58aeac6a8651a5e7c405bbbab837f73d89fb2

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

git commit -am 'Backport PR #14510: Fix numpy 1.25 deprecation warnings.'

4. Push to a named branch:

git push YOURFORK v5.2.x:auto-backport-of-pr-14510-on-v5.2.x

5. Create a PR against branch v5.2.x, I would have named this PR:

"Backport PR #14510 on branch v5.2.x (Fix numpy 1.25 deprecation warnings.)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.