[bug] MacOS build replaces version with literal https in download URL

[yozachar]

Repository | Failed run

linux

  Switched to branch '7a122abe5c15b92ec5980aa3f9c28f59344367cb'
  redirect url: https://github.com/pypa/pipx/releases/tag/1.2.0
  * Downloading pipx release 1.2.0...
  pipx 1.2.0 installation was successful!
  1.2.0

macos

 Switched to branch '7a122abe5c15b92ec5980aa3f9c28f59344367cb'
  redirect url: https://github.com/pypa/pipx/releases/tag/1.2.0
  * Downloading pipx release https...
  curl: (22) The requested URL returned error: 404
  asdf-pipx: Could not download https://github.com/pypa/pipx/releases/download/https/pipx.pyz
  FAILED: install exited with an error

Why?

[jthegedus]

I've seen this Issue, had a brief look and couldn't identify anything specific. I looked at other plugins recently added to the repository to see if they had similar issues, and they do not.

• https://github.com/pdemagny/asdf-vale
• https://github.com/xeedio/asdf-cyclonedx
• https://github.com/TheOpenDictionary/asdf-flatc

This plugin template is meant to be a starting point, your plugin may require specific modification.

[jthegedus]

Perhaps your plugin was having issues because of the latest-stable script. We just updated/fixed support for macOS in asdf-vm/asdf-plugin-template#65

Please try updating your plugin with that change.

[jthegedus]

I don't believe the fix for your issue is in the Action itself, because the action is just executing your plugin which is the point of failure.

[yozachar]

Well this indeed was the problem:

https://github.com/asdf-vm/asdf-plugin-template/pull/65/files

-    version="$(printf "%s\n" "$redirect_url" | sed 's|.*/tag/v\?||')"
+    version="$(printf "%s\n" "$redirect_url" | sed 's|.*/tag/v\{0,1\}||')"

Last run

Fixed by: asdf-vm/asdf-plugin-template#65