fix: make the sed expression work for non-GNU sed

[dochang]

Use ERE instead, because GitHub Actions doesn't use GNU sed on macOS by default.

[jthegedus]

From memory we don't use sed -E flag in the asdf core because it is also not very portable. We use regular sed without -E in the core and our tests mostly fine. What's the case that is failing that requires this?

[dochang]

Thanks for your reply.

Last week I submitted a patch makes latest-stable support version numbers without "v" prefix. But I found that my plugin's test failed on macos on Github Actions.

The reason

The reason is that Github Actions uses BSD sed by default, which uses a different BRE syntax from GNU sed.

Check this commit 6c2416e and its action run 4734069256, latest-stable fails on macos when sed 's|.*/tag/v\?||' is used.

According to the manual of GNU sed, \? is an extensions:

\?

As *, but only matches zero or one. It is a GNU extension.

Instead, macos uses ?, according to this manpage:

An atom followed by '?' matches a sequence of 0 or 1 matches of the atom.

Possible solutions

We have two choices:

1. Replace \? with \{0,1\}

See this commit 83448d7 and its action run 4734486470

2. Use sed -E (ERE)

According to this manpage, macos has supported ERE since 2005.

See this commit ef8ec79 and its action run 4734836943

Conclusion

Both solutions are ok. I prefer ERE. So I send this PR.

[jthegedus]

I would prefer a solution without -E. Although macOS supports it, users run asdf on Alpine amongst other linux distros which may not have -E support in the way we expect. We don't currently test for all OS permutations of our users. Just the fact we don't use -E in the core means I don't want to introduce it in the plugin-template.

[dochang]

That makes sense. Let's go with \{0,1\}.

[dochang]

@jthegedus A new commit has been pushed into this PR.

[jthegedus]

Thanks!