Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future-proof against changes to git read-tree --prefix #53

Closed
rellen opened this issue Jul 19, 2022 · 3 comments
Closed

Future-proof against changes to git read-tree --prefix #53

rellen opened this issue Jul 19, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@rellen
Copy link
Contributor

rellen commented Jul 19, 2022

Is your feature request related to a problem? Please describe.

Recent versions of git will disallow git read-tree --prefix=/ ...
See: https://www.spinics.net/lists/git/msg433678.html
The template will fail if using a recent version of git.
Tested on git version 2.36.0

Already on 'template'
Preparing worktree (detached HEAD 843b4d4)
HEAD is now at 843b4d4 Initial commit
Switched to a new branch 'out'
fatal: Invalid prefix, prefix cannot start with '/'

Describe the solution you'd like

git read-tree --prefix="" ... seems to work for setup.bash changing the below line.
https://github.com/asdf-vm/asdf-plugin-template/blob/main/setup.bash#L170

I am not sure if this is the most robust solution.

Thanks for providing this template!

@rellen rellen added the enhancement New feature or request label Jul 19, 2022
@jthegedus
Copy link
Collaborator

Thanks for the report, makes sense to me. Are you able to create a PR?

@rellen
Copy link
Contributor Author

rellen commented Jul 19, 2022

@jthegedus PR created :)

@jthegedus
Copy link
Collaborator

jthegedus commented Jul 20, 2022

closed in #54
Thanks @rellen

joao-fontenele added a commit to joao-fontenele/asdf-plugin-template that referenced this issue Jan 31, 2024
see asdf-vm#53 for a similar fix for the github flow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants