Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing should not affect hidden layers #2428

Open
cri5ti opened this issue Jun 6, 2020 · 4 comments
Open

Editing should not affect hidden layers #2428

cri5ti opened this issue Jun 6, 2020 · 4 comments
Labels

Comments

@cri5ti
Copy link

cri5ti commented Jun 6, 2020

Editing should not affect hidden layers, but if you just changed the current frame by clicking on a new frame, edits will affect hidden layers, which is counter intuitive, and you usually don't notice until much later.

9

  • Aseprite version: v1.2.17-x64 (tried in v1.2.19.2-x64)
  • System: Windows
@sumibi-yakitori
Copy link
Contributor

I don't see a particular problem with this, as I can simply lock the layers. The current aseprite behavior is necessary for me.

@hiddenhare
Copy link

Reproduced this in Aseprite 1.2.25-x64, Windows 10. I agree that it feels like a UX bug.

  • The behaviour is inconsistent before and after changing frames with a selection active. (Before, only selected layers are edited when moving or deleting a selection; after, all layers are edited.)

  • The behaviour is also inconsistent with locked layers. As far as I can tell, there's no way to move the content of a locked layer.

  • The behaviour is inconsistent with all other tools (including the Move tool), which will refuse to operate when only hidden layers are selected.

  • The consequences for accidental editing of hidden content can be severe. In the worst case, the user might accidentally delete or ruin several layers, and then save their work.

@thomasgoldstein
Copy link

I'm seeing a quite unsettling behavior which is most likely linked to the one described here, so I'm sharing this here instead of creating a new issue. It's not just that you can edit hidden layers, it's also the fact moving a selection on a hidden layer results is completely deleting the whole selection, somehow.

Example:

  • Have a layer which contains graphics
  • Hide that layer
  • Create a big selection on that hidden layer (in a place where the graphics should be), then move that selection to any direction by 1px
  • Show the layer again

Result: everything you selected and moved has completely disappeared. That is to say it does not behave as it would if the layer was visible the whole time.

@dacap dacap added the bug label Jan 12, 2022
@dacap dacap self-assigned this Jan 12, 2022
@dacap
Copy link
Member

dacap commented Jan 12, 2022

I thought this bug was fixed, but it looks like it's still present when the active layer is the hidden one. Thanks for reporting @thomasgoldstein

@dacap dacap removed their assignment Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants