Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode for window decoration on windows #3527

Closed
lampysprites opened this issue Sep 17, 2022 · 3 comments
Closed

Dark mode for window decoration on windows #3527

lampysprites opened this issue Sep 17, 2022 · 3 comments

Comments

@lampysprites
Copy link
Contributor

lampysprites commented Sep 17, 2022

So it seems windows disables the dark mode support by default, and leaves it to the application to enable. I think it only affects the inactive window border - instead of becoming dark gray in dark mode, it becomes bright white. It is not a disaster but stands out when there's other applications open.

Current behavior in both modes, active/inactive:
ZUOQh67NTJ

Desired dark mode:
EsgYIrJebO

I tried to support that based on the second half of microsoft's guide... however, now the exact opposite happens and the window uses dark mode always. It seems that that part of the API went through a series of changes, and it only works since win11 and i can't figure where older docs went (re: DWMWA_USE_IMMERSIVE_DARK_MODE).

Perhaps i could make it switch according to preferences? Although that is not native behavior, it at least will be an option.

darkmode.patch.zip

Aseprite and System version

  • Aseprite version: 1.3-beta21 steam; and git
  • System: Windows 10
@lampysprites
Copy link
Contributor Author

Meanwhile, a workaround was to create HKCU\Software\Microsoft\Windows\DWM\AccentColorInactive key with dword value of 0xff2b2b2b, which also fixes all other applications that have white title bars.

@Gasparoken
Copy link
Member

Thanks for your report and for making progress in the analysis.

@dacap
Copy link
Member

dacap commented Aug 16, 2023

We'll support the dark mode on Windows 11 but not on Windows 10.

Some extra discussion here: microsoft/WindowsAppSDK#41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants